Invalid preset shown

[mondalaci]

After starting up Agent and visiting the typing behavior page, I see:

Then I click the simple button, which shouldn't change the settings, assuming that the simple preset was already active, but it changes:

[ert78gb]

The Simple preset is not a real preset. It has values to simulate the behaviour of a preset on the UI, but Simple preset is selected on the UI when the secondaryRoleStrategy === 'Simple'.

The first screen rendered because these are the values in the user config of the keyboard. These are the values in the default user config too. I mentioned it earlier, maybe we have to change the default values in the default user config too.
Technically, the firmware does not use these values it has custom logic when the secondaryRoleStrategy === 'Simple'

The second screen rendered because these are the "values" of the simulated Simple preset.

[mondalaci]

In my mind, every preset except Custom should correspond to an exact set of values; otherwise, Custom should be selected. Do you agree, @kareltucek?

[kareltucek]

Let's say that I agree that this is confusing.

The way I see it, when simple is lit up, the simple preset values should be shown. Whether they should be actually written or not is a UX question of a lower importance, to which both answers seem acceptable to me.

[mhantsch]

But something is wrong with the preset vs. custom settings.

I have my own custom settings, so Agent opens with the Custom preset selected.
I then click on some other preset, f.x. HRM-timeout-secondary, and the values change.
If I now click on Custom again, values go back to my custom settings.

I then click on some other preset, f.x. HRM-timeout-secondary, and the values change.
I then click on a second other preset, f.x. HRM-timeout-cancel, and the values change again.
If I now click on Custom, values do NOT go back to my custom settings, but they seem to go back to the first selected preset, e.g. they are now the same as HRM-timeout-secondary. But I would have expected them to be my custom values.