Skip to content

fix(checkout): surface auto-login failures#1363

Merged
superdav42 merged 1 commit into
mainfrom
feature/auto-20260609-110524
Jun 9, 2026
Merged

fix(checkout): surface auto-login failures#1363
superdav42 merged 1 commit into
mainfrom
feature/auto-20260609-110524

Conversation

@superdav42

Copy link
Copy Markdown
Collaborator

Summary

  • Stop checkout before gateway handoff when wp_signon() fails during automatic post-signup login.
  • Return a user-visible checkout_login_failed error that includes the upstream WordPress/plugin login failure message.
  • Add regression coverage for the password-path auto-login failure case.

Verification

  • php -l inc/checkout/class-checkout.php
  • php -l tests/WP_Ultimo/Checkout/Checkout_Test.php
  • vendor/bin/phpcs inc/checkout/class-checkout.php
  • vendor/bin/phpunit --filter test_login_customer_after_checkout_with_password_returns_error_when_signon_fails

aidevops.sh v3.20.43 plugin for OpenCode v1.16.2 with gpt-5.5 spent 1h 27m and 1,973,291 tokens on this with the user in an interactive session.

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@superdav42, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 16 minutes and 42 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c8d1821a-8638-420f-b7da-955052dad492

📥 Commits

Reviewing files that changed from the base of the PR and between 1d45e8b and be4b4a7.

📒 Files selected for processing (2)
  • inc/checkout/class-checkout.php
  • tests/WP_Ultimo/Checkout/Checkout_Test.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/auto-20260609-110524

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@superdav42 superdav42 merged commit dda1a0a into main Jun 9, 2026
11 checks passed
@superdav42

Copy link
Copy Markdown
Collaborator Author

Summary

  • Stop checkout before gateway handoff when wp_signon() fails during automatic post-signup login.
  • Return a user-visible checkout_login_failed error that includes the upstream WordPress/plugin login failure message.
  • Add regression coverage for the password-path auto-login failure case.

Verification

  • php -l inc/checkout/class-checkout.php
  • php -l tests/WP_Ultimo/Checkout/Checkout_Test.php
  • vendor/bin/phpcs inc/checkout/class-checkout.php
  • vendor/bin/phpunit --filter test_login_customer_after_checkout_with_password_returns_error_when_signon_fails

aidevops.sh v3.20.43 plugin for OpenCode v1.16.2 with gpt-5.5 spent 1h 27m and 1,973,291 tokens on this with the user in an interactive session.


Merged via PR #1363 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant