Handle new Discord error codes and improve error messaging (#116)

* Handle new Discord error codes and i18n messages

Add handling for additional Discord API error codes (30013: max channels; 160005: thread locked; 160006: max active threads; 160007: max active announcement threads) and return corresponding localized messages. Introduce a docsUrl variable to centralize the docs link and use a new MessageErrorMissingAccess message when access is denied or permissions cannot be determined. Update i18n message IDs to include max_channels, thread_locked, max_active_threads, max_active_announcement_threads, and missing_access.

* Handle channel creation error before closing ticket

When CreateGuildChannel fails, call cmd.HandleError(err) immediately and remove the duplicate call later. This ensures the original channel creation error is surfaced before attempting ticket cleanup (closing the ticket) and avoids handling the same error twice. No behavioral change to the subsequent REST error handling logic.

Author: biast12

bot/command/context/replyable.go

@@ -204,10 +204,13 @@ func (r *Replyable) buildErrorResponse(err error, eventId string, includeInviteL
 			message = r.GetMessage(i18n.MessageErrorUnknownInteraction)
 		} else if restError.ApiError.Code == 30007 { // Maximum number of webhooks reached
 			message = r.GetMessage(i18n.MessageErrorMaxWebhooks)
+		} else if restError.ApiError.Code == 30013 { // Maximum number of guild channels reached
+			message = r.GetMessage(i18n.MessageErrorMaxChannels)
 		} else if restError.ApiError.Code == 40060 { // Interaction has already been acknowledged
 			message = r.GetMessage(i18n.MessageErrorInteractionAcknowledged)
 		} else if restError.ApiError.Code == 50001 || restError.ApiError.Code == 50013 { // Missing permissions / Missing access
 			interactionCtx, ok := r.ctx.(registry.InteractionContext)
+			docsUrl := fmt.Sprintf("%s/miscellaneous/permissions-explained", config.Conf.Bot.DocsUrl)
 			if ok {
 				missingPermissions, err := findMissingPermissions(interactionCtx)
 				if err == nil {
@@ -217,16 +220,16 @@ func (r *Replyable) buildErrorResponse(err error, eventId string, includeInviteL
 							message += fmt.Sprintf("* `%s`\n", perm.String())
 						}
 
-						message += "\n" + r.GetMessage(i18n.MessageErrorMissingPermissionsBody, fmt.Sprintf("%s/miscellaneous/permissions-explained", config.Conf.Bot.DocsUrl))
+						message += "\n" + r.GetMessage(i18n.MessageErrorMissingPermissionsBody, docsUrl)
 					} else {
-						message = r.formatDiscordError(restError, eventId)
+						message = r.GetMessage(i18n.MessageErrorMissingAccess, docsUrl)
 					}
 				} else {
 					sentry.ErrorWithContext(err, r.ctx.ToErrorContext())
-					message = r.formatDiscordError(restError, eventId)
+					message = r.GetMessage(i18n.MessageErrorMissingAccess, docsUrl)
 				}
 			} else {
-				message = r.formatDiscordError(restError, eventId)
+				message = r.GetMessage(i18n.MessageErrorMissingAccess, docsUrl)
 			}
 		} else if restError.ApiError.Code == 50035 { // Invalid Form Body
 			// Check for specific form validation errors
@@ -248,6 +251,12 @@ func (r *Replyable) buildErrorResponse(err error, eventId string, includeInviteL
 				message = r.GetMessage(i18n.MessageErrorInvalidForm) + "\n\n" +
 					r.formatDiscordError(restError, eventId)
 			}
+		} else if restError.ApiError.Code == 160005 { // Thread is locked
+			message = r.GetMessage(i18n.MessageErrorThreadLocked)
+		} else if restError.ApiError.Code == 160006 { // Maximum number of active threads reached
+			message = r.GetMessage(i18n.MessageErrorMaxActiveThreads)
+		} else if restError.ApiError.Code == 160007 { // Maximum number of active announcement threads reached
+			message = r.GetMessage(i18n.MessageErrorMaxActiveAnnouncementThreads)
 		} else if restError.StatusCode == http.StatusTooManyRequests {
 			// Rate limit error - parse raw response to extract retry_after and global flag
 			var rateLimit rateLimitResponse

bot/logic/open.go

@@ -369,13 +369,13 @@ func OpenTicket(ctx context.Context, cmd registry.InteractionContext, panel *dat
 		reasonCtx := request.WithAuditReason(context.Background(), auditReason)
 		tmp, err := cmd.Worker().CreateGuildChannel(reasonCtx, cmd.GuildId(), data)
 		if err != nil { // Bot likely doesn't have permission
+			cmd.HandleError(err)
+
 			// To prevent tickets getting in a glitched state, we should mark it as closed (or delete it completely?)
 			if err := dbclient.Client.Tickets.Close(ctx, ticketId, cmd.GuildId()); err != nil {
 				cmd.HandleError(err)
 			}
 
-			cmd.HandleError(err)
-
 			var restError request.RestError
 			if errors.As(err, &restError) && restError.ApiError.FirstErrorCode() == "CHANNEL_PARENT_MAX_CHANNELS" {
 				canRefresh, err := redis.TakeChannelRefetchToken(ctx, cmd.GuildId())

i18n/messages.go

@@ -290,31 +290,36 @@ var (
 	MessageButtonGuildOnly MessageId = "button.guild_only"
 	MessageButtonDMOnly    MessageId = "button.dms_only"
 
-	MessageErrorUnknownChannel          MessageId = "errors.unknown_channel"
-	MessageErrorUnknownGuild            MessageId = "errors.unknown_guild"
-	MessageErrorUnknownMember           MessageId = "errors.unknown_member"
-	MessageErrorUnknownMessage          MessageId = "errors.unknown_message"
-	MessageErrorUnknownUser             MessageId = "errors.unknown_user"
-	MessageErrorUnknownRole             MessageId = "errors.unknown_role"
-	MessageErrorUnknownCategory         MessageId = "errors.unknown_category"
-	MessageErrorUnknownInteraction      MessageId = "errors.unknown_interaction"
-	MessageErrorMaxWebhooks             MessageId = "errors.max_webhooks"
-	MessageErrorInteractionAcknowledged MessageId = "errors.interaction_acknowledged"
-	MessageErrorMissingPermissionsTitle MessageId = "errors.missing_permissions.title"
-	MessageErrorMissingPermissionsBody  MessageId = "errors.missing_permissions.body"
-	MessageErrorInvalidLength           MessageId = "errors.invalid_length"
-	MessageErrorRequiredField           MessageId = "errors.required_field"
-	MessageErrorInvalidChannelType      MessageId = "errors.invalid_channel_type"
-	MessageErrorInvalidCategory         MessageId = "errors.invalid_category"
-	MessageErrorInvalidId               MessageId = "errors.invalid_id"
-	MessageErrorInvalidCharacters       MessageId = "errors.invalid_characters"
-	MessageErrorInvalidChoice           MessageId = "errors.invalid_choice"
-	MessageErrorInvalidForm             MessageId = "errors.invalid_form"
-	MessageErrorTimeout                 MessageId = "errors.timed_out"
-	MessageErrorRateLimited             MessageId = "errors.rate_limited"
-	MessageErrorRateLimitedGlobal       MessageId = "errors.rate_limited_global"
-	MessageErrorGeneral                 MessageId = "errors.general"
-	MessageErrorId                      MessageId = "errors.error_id"
+	MessageErrorUnknownChannel               MessageId = "errors.unknown_channel"
+	MessageErrorUnknownGuild                 MessageId = "errors.unknown_guild"
+	MessageErrorUnknownMember                MessageId = "errors.unknown_member"
+	MessageErrorUnknownMessage               MessageId = "errors.unknown_message"
+	MessageErrorUnknownUser                  MessageId = "errors.unknown_user"
+	MessageErrorUnknownRole                  MessageId = "errors.unknown_role"
+	MessageErrorUnknownCategory              MessageId = "errors.unknown_category"
+	MessageErrorUnknownInteraction           MessageId = "errors.unknown_interaction"
+	MessageErrorMaxWebhooks                  MessageId = "errors.max_webhooks"
+	MessageErrorMaxChannels                  MessageId = "errors.max_channels"
+	MessageErrorInteractionAcknowledged      MessageId = "errors.interaction_acknowledged"
+	MessageErrorMissingPermissionsTitle      MessageId = "errors.missing_permissions.title"
+	MessageErrorMissingPermissionsBody       MessageId = "errors.missing_permissions.body"
+	MessageErrorMissingAccess                MessageId = "errors.missing_access"
+	MessageErrorInvalidLength                MessageId = "errors.invalid_length"
+	MessageErrorRequiredField                MessageId = "errors.required_field"
+	MessageErrorInvalidChannelType           MessageId = "errors.invalid_channel_type"
+	MessageErrorInvalidCategory              MessageId = "errors.invalid_category"
+	MessageErrorInvalidId                    MessageId = "errors.invalid_id"
+	MessageErrorInvalidCharacters            MessageId = "errors.invalid_characters"
+	MessageErrorInvalidChoice                MessageId = "errors.invalid_choice"
+	MessageErrorInvalidForm                  MessageId = "errors.invalid_form"
+	MessageErrorThreadLocked                 MessageId = "errors.thread_locked"
+	MessageErrorMaxActiveThreads             MessageId = "errors.max_active_threads"
+	MessageErrorMaxActiveAnnouncementThreads MessageId = "errors.max_active_announcement_threads"
+	MessageErrorTimeout                      MessageId = "errors.timed_out"
+	MessageErrorRateLimited                  MessageId = "errors.rate_limited"
+	MessageErrorRateLimitedGlobal            MessageId = "errors.rate_limited_global"
+	MessageErrorGeneral                      MessageId = "errors.general"
+	MessageErrorId                           MessageId = "errors.error_id"
 
 	HelpAdmin              MessageId = "help.admin"
 	HelpAdminDebug         MessageId = "help.admin.debug"