GLA Technical kills/damages building when dying by China Mines

[DrGoldFish1]

Prerequisites

• I have searched for similar issues and confirmed this is not a duplicate

Game Version

• Command & Conquer Generals
• Command & Conquer Generals: Zero Hour
• Other (please specify below)

Bug Description

I have only tested this bug with technicals, but I have seen this happen with dead migs and chinooks before.

What I believe is happening is the Husk of the unit is dealing damage when it lands on the ground, but cause of the mines or hitbox of the building the hush is unable to touch the ground causing it to lightly elevate above the ground dealing damage for every frame this husk is in this state.

On retail this bug is less likely to actually kill the building but still possible, while on generalsonline the building takes more damage faster and has a high chance to die. Most likely has something to do with the FPS being higher.

This is on Retail
https://github.com/user-attachments/assets/4a0298d2-00fe-4523-9b61-ff98425e9f18

This is on GeneralsOnline
https://github.com/user-attachments/assets/984ff6ff-a16d-43b7-bae9-bc01d21a5b8d

For Testing I did make a map.ini file that makes the mass of the technical higher so it is more likely to copy this behaviour.

Reproduction Steps

For Faster reproducing use this map, where I changed the mass of the technical to be 120 instead of 40, this makes this bug more likely to happen.
[Testing] Bugs.zip

1. Get a china building with mines around it, best to take a propaganda center cause of it having low HP
2. Drive over the mines with a technical

Additional Context

No response

[Caball009]

Would need to verify if GlobalData::m_gravity needs to be adjusted for non-default logic frame rates. The way it's initialized from the ini file assumes the default value of 30 logic frames per second.

[DrGoldFish1]

With some testing I can confirm that the damage being done by Chinooks, helix, jets and technical is caused by VehicleCrashesIntoBuildingWeapon and VehicleCrashesIntoNonBuildingWeapon Both doing 30 damage on impact. This damage is applied for every frame the weapon is active for.

This weapon gets disabled when the hulk is touching the ground or m_delayFromGroundToFinalDeath reaches 0, This has 1,5 seconds delay. So if the hulk is landing on the mines, it floats 1ft in the air, 1ft is also the hight this weapon is getting activated at.
The same can happen for when a dead mig lands on units like an avengers.

This allows the hulk to do 30 damage for each frame since there is no clipsize or delaybetween shots assigned. Then for a max value of 1.5 seconds, so 30x45frames and on generals online this is 30x90frames. Shortening m_delayFromGroundToFinalDeath does help reduce this effect but not a real solution.

I am going to leave this topic to those who have a better understanding on how to fix this. Since I am no dev.

[Piddox]

@L3-M you added the tag Minor to this. For 1.04 this makes sense since it happens extremely rarely there. But in GO (60FPS) I would classify it as Major or even Critical, given how often it happens and how impacting it is on the outcome of the game if it does happen. Most recent example from today in GO: https://www.youtube.com/clip/Ugkxgm2qo2QbJlA-61v2pg8Q2PsqAWT8-NVI And I see these example clips dropping by on a weekly basis, even though only a small percentage of games are being recorded.

[L3-M]

@L3-M you added the tag Minor to this. For 1.04 this makes sense since it happens extremely rarely there. But in GO (60FPS) I would classify it as Major or even Critical, given how often it happens and how impacting it is on the outcome of the game if it does happen. Most recent example from today in GO: https://www.youtube.com/clip/Ugkxgm2qo2QbJlA-61v2pg8Q2PsqAWT8-NVI And I see these example clips dropping by on a weekly basis, even though only a small percentage of games are being recorded.

Currently, retail incompatible bugs are a low priority for us since we have other things to worry about for the first release which is retail compatible.

Also does this bug occur in the retail incompatible TheSuperHackers client at the same frequency as in the Generals Online 60HZ client? If not then this is likely related to the implementation of the 60Hz and because of that, this bug priority is minor and make more sense to be reported and fixed in the GO client for now.

[xezon]

In principle, is the vehicle crash damage considered okay in Retail game? Or is it too strong or too inconsistent?

[DrGoldFish1]

In retail game it does still do loads of damage but not enough most of the time to kill the buildings since it is the damage x45 frames total instead of the damage x 90frames. since the code is giving a max damage of 1,5sec worth of damage. preferably the code only force it to do 1 frame worth of damage so no matter if the unit bugs out. It does not do extra damage.

[Piddox]

In retail game it does still do loads of damage but not enough most of the time to kill the buildings since it is the damage x45 frames total instead of the damage x 90frames. since the code is giving a max damage of 1,5sec worth of damage. preferably the code only force it to do 1 frame worth of damage so no matter if the unit bugs out. It does not do extra damage.

It also just happens waaaaaaay less frequently. In 1.04 it's a rarity to see this, in GO it happens all the time.