fix: find & replace — Replace / Replace All buttons not working

Two bugs in editor-features.js:

1. wireFind('find-') constructed wrong IDs (find-find-input, find-replace-all)
   instead of actual HTML IDs (find-input, replace-all); no click handlers
   were attached to legacy bar Replace/All buttons

2. getActiveFindEls() always resolved to QAB elements because the QAB
   container has display:flex even when the full header is shown; performFind
   and replaceAll read from empty QAB inputs while user typed in legacy bar

Fix: replaced wireFind(prefix) with wireFindSet(ids) using explicit ID maps;
changed getActiveFindEls to check qabFindSection.style.display === 'flex'

Author: ijbo

changelogs/CHANGELOG-find-replace-fix.md

@@ -0,0 +1,14 @@
+# Fix: Find & Replace — Replace / Replace All not working
+
+## Root Cause
+
+Two bugs in `js/editor-features.js`:
+
+1. **Wrong element IDs in `wireFind('find-')`** — The prefix-based ID construction produced IDs like `find-find-input` and `find-replace-all` instead of the actual HTML IDs (`find-input`, `replace-all`). No click handlers were ever attached to the legacy find bar's Replace and Replace All buttons.
+
+2. **`getActiveFindEls()` always resolved to QAB elements** — It checked `qab.style.display !== 'none'`, but the QAB container always has `display: flex`. So `performFind()`, `replaceOne()`, and `replaceAll()` read from the empty QAB inputs while the user was typing into the legacy find bar.
+
+## Fix
+
+- Replaced `wireFind(prefix)` with `wireFindSet(ids)` that takes explicit ID maps for each set of elements.
+- Changed `getActiveFindEls()` to check `qabFindSection.style.display === 'flex'` — only true when the QAB find section is explicitly opened.

js/editor-features.js

@@ -423,8 +423,8 @@
 
     // Resolve elements: prefer QAB inline if QAB is visible, else fall back to legacy bar
     function getActiveFindEls() {
-        var qab = document.getElementById('quick-action-bar');
-        var useQab = qab && qab.style.display !== 'none' && qabFindSection;
+        // Use QAB inputs only when the QAB find section is explicitly open (display: flex)
+        var useQab = qabFindSection && qabFindSection.style.display === 'flex';
         return {
             findInput: document.getElementById(useQab ? 'qab-find-input' : 'find-input'),
             replaceInput: document.getElementById(useQab ? 'qab-replace-input' : 'replace-input'),
@@ -559,15 +559,15 @@
         performFind();
     }
 
-    // Wire up BOTH sets of elements (legacy bar + QAB inline)
-    function wireFind(prefix) {
-        var fi = document.getElementById(prefix + 'find-input') || document.getElementById(prefix + '-find-input');
-        var rt = document.getElementById(prefix + 'regex-toggle') || document.getElementById(prefix + '-regex-toggle');
-        var fp = document.getElementById(prefix + 'find-prev') || document.getElementById(prefix + '-find-prev');
-        var fn = document.getElementById(prefix + 'find-next') || document.getElementById(prefix + '-find-next');
-        var ro = document.getElementById(prefix + 'replace-one') || document.getElementById(prefix + '-replace-one');
-        var ra = document.getElementById(prefix + 'replace-all') || document.getElementById(prefix + '-replace-all');
-        var ri = document.getElementById(prefix + 'replace-input') || document.getElementById(prefix + '-replace-input');
+    // Wire up find/replace event listeners for a set of elements by their actual IDs
+    function wireFindSet(ids) {
+        var fi = document.getElementById(ids.findInput);
+        var rt = document.getElementById(ids.regexToggle);
+        var fp = document.getElementById(ids.findPrev);
+        var fn = document.getElementById(ids.findNext);
+        var ro = document.getElementById(ids.replaceOne);
+        var ra = document.getElementById(ids.replaceAll);
+        var ri = document.getElementById(ids.replaceInput);
         if (fi) fi.addEventListener('input', performFind);
         if (fp) fp.addEventListener('click', findPrev);
         if (fn) fn.addEventListener('click', findNext);
@@ -589,13 +589,21 @@
         if (ri) ri.addEventListener('keydown', function (e) { if (e.key === 'Escape') M.closeFindBar(); });
     }
 
-    // Wire legacy bar elements
-    wireFind('find-');
+    // Wire legacy bar elements (IDs: find-input, replace-input, find-prev, etc.)
+    wireFindSet({
+        findInput: 'find-input', replaceInput: 'replace-input',
+        regexToggle: 'find-regex-toggle', findPrev: 'find-prev', findNext: 'find-next',
+        replaceOne: 'replace-one', replaceAll: 'replace-all'
+    });
     var findCloseBtn = document.getElementById('find-close');
     if (findCloseBtn) findCloseBtn.addEventListener('click', M.closeFindBar);
 
-    // Wire QAB inline elements
-    wireFind('qab-');
+    // Wire QAB inline elements (IDs: qab-find-input, qab-replace-input, etc.)
+    wireFindSet({
+        findInput: 'qab-find-input', replaceInput: 'qab-replace-input',
+        regexToggle: 'qab-regex-toggle', findPrev: 'qab-find-prev', findNext: 'qab-find-next',
+        replaceOne: 'qab-replace-one', replaceAll: 'qab-replace-all'
+    });
 
     // ========================================
     // WORD WRAP TOGGLE