Skip to content

Commit 8ace484

Browse files
committed
fix(table-core): use autoRemove instead of resolveFilterValue on comparison filter fns
filterFn_greaterThan, filterFn_greaterThanOrEqualTo, filterFn_lessThan, and filterFn_lessThanOrEqualTo incorrectly used .resolveFilterValue instead of .autoRemove. This corrupted filter values — e.g. "price > 50" became "price > false" (coerced to "price > 0") because testFalsy(50) returns false, and false is not nullish so the ?? fallback doesn't apply. Fixes #6212
1 parent e59f732 commit 8ace484

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

packages/table-core/src/fns/filterFns.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ export const filterFn_greaterThan: FilterFn<any, any> = <
141141
return stringValue > stringFilterValue
142142
}
143143

144-
filterFn_greaterThan.resolveFilterValue = (val: any) => testFalsy(val)
144+
filterFn_greaterThan.autoRemove = (val: any) => testFalsy(val)
145145

146146
/**
147147
* Filter function for checking if a number is greater than or equal to a given number.
@@ -160,7 +160,7 @@ export const filterFn_greaterThanOrEqualTo: FilterFn<any, any> = <
160160
)
161161
}
162162

163-
filterFn_greaterThanOrEqualTo.resolveFilterValue = (val: any) => testFalsy(val)
163+
filterFn_greaterThanOrEqualTo.autoRemove = (val: any) => testFalsy(val)
164164

165165
/**
166166
* Filter function for checking if a number is less than a given number.
@@ -176,7 +176,7 @@ export const filterFn_lessThan: FilterFn<any, any> = <
176176
return !filterFn_greaterThanOrEqualTo(row as any, columnId, filterValue)
177177
}
178178

179-
filterFn_lessThan.resolveFilterValue = (val: any) => testFalsy(val)
179+
filterFn_lessThan.autoRemove = (val: any) => testFalsy(val)
180180

181181
/**
182182
* Filter function for checking if a number is less than or equal to a given number.
@@ -192,7 +192,7 @@ export const filterFn_lessThanOrEqualTo: FilterFn<any, any> = <
192192
return !filterFn_greaterThan(row as any, columnId, filterValue)
193193
}
194194

195-
filterFn_lessThanOrEqualTo.resolveFilterValue = (val: any) => testFalsy(val)
195+
filterFn_lessThanOrEqualTo.autoRemove = (val: any) => testFalsy(val)
196196

197197
// Range filters
198198

0 commit comments

Comments
 (0)