Calling "instantiatedType" on an "InstantiationExpression" with its missing require membership causes an NPE

[adaussy]

Calling "instantiatedType" on an "InstantiationExpression" might end up in a NullPointException with the "InstantiationExpression" missing its required "Membership".

Exception in thread "main" java.lang.NullPointerException
	at java.base/java.util.Objects.requireNonNull(Objects.java:233)
	at java.base/java.util.Optional.of(Optional.java:113)
	at java.base/java.util.stream.FindOps$FindSink$OfRef.get(FindOps.java:194)
	at java.base/java.util.stream.FindOps$FindSink$OfRef.get(FindOps.java:191)
	at java.base/java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:150)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:647)
	at org.omg.sysml.delegate.invocation.InstantiationExpression_instantiatedType_InvocationDelegate.dynamicInvoke(InstantiationExpression_instantiatedType_InvocationDelegate.java:47)

[seidewitz]

Do you have a model in textual notation that produces this error? Or does the invalid model have to be created programmatically?

[adaussy]

I'm working for Obeo and I was told that we were allowed to work on this implementation. Am I wrong?

I was avour to provide a JUnit in the attached PR but you closed it so I am not more able to do it.

package org.omg.sysml.logic;

import java.lang.reflect.InvocationTargetException;

import org.eclipse.emf.ecore.InternalEObject;
import org.junit.BeforeClass;
import org.junit.Test;
import org.omg.sysml.delegate.invocation.InstantiationExpression_instantiatedType_InvocationDelegate;
import org.omg.sysml.lang.sysml.InvocationExpression;
import org.omg.sysml.lang.sysml.SysMLFactory;
import org.omg.sysml.lang.sysml.SysMLPackage;

public class InstantiationExpression_instantiatedType_InvocationDelegateTest {

	@BeforeClass
	public static void setUp() {
		SysMLLogicStandaloneSetup.doSetup();
	}
	@Test
	public void incompleteInstantiationExpression() throws InvocationTargetException {
		// Should not throw an NPE
		InvocationExpression invocationExpression = SysMLFactory.eINSTANCE.createInvocationExpression();
		invocationExpression.getOwnedRelationship().add(SysMLFactory.eINSTANCE.createMembership());
		new InstantiationExpression_instantiatedType_InvocationDelegate(SysMLPackage.eINSTANCE.getInstantiationExpression__InstantiatedType())
			.dynamicInvoke((InternalEObject) invocationExpression,null);
	}
	
}

[seidewitz]

Yes, Obeo is a SMC member, so it is possible for you to contribute. However, you need to join the RIWG development process. We track and schedule work into Sprints on a private Jira, and we only create feature branches and PRs based on assigned tasks in that Jira.

If you would like to participate, please join the Reference Implementation WG on OMG Causeway system, and you will get invited to our Wednesday planning sessions (which are not every Wednesday this month, due to travel and vacation). If you haven't already, you should coordinate with @AxelRICHARD from Obeo, who is already working on the RIWG.

[adaussy]

Ok, I'm working with him, I first created this issue because I was not aware of the process. Then he told me that I needed to use JIRA so I ask him to create ST6RI-938. I will get in touch with him to see what else I need to do.

Thanks for the feedback.

[AxelRICHARD]

I will submit the PR to ease the process.