From f62811bf74449a9ca94f2ada836886581a619a08 Mon Sep 17 00:00:00 2001
From: "vivi-the-going-merry[bot]"
 <308115520+vivi-the-going-merry[bot]@users.noreply.github.com>
Date: Thu, 24 Sep 2026 20:18:23 -0600
Subject: [PATCH 1/2] Remove invalid aria-label on SMTP page install/activate
 link

The "Install"/"Activate WP Mail SMTP" <a> on the SMTP settings admin
page has no href, so it takes the implicit ARIA role "generic" -
which doesn't support aria-label per the aria_attribute_valid rule.
The link's visible text ("Install WP Mail SMTP" / "Activate WP Mail
SMTP") already conveys its purpose, so the attribute (and the
button_action value that only ever fed it) is removed rather than
given a role.

Verified with IBM's accessibility-checker CLI against the real
rendered admin page (formidable-preview-env): the aria_attribute_valid
violation on this element is gone after the fix, with no change to
any other violation.

Fixes Strategy11/formidable-pro#6759
---
 classes/controllers/FrmSMTPController.php | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/classes/controllers/FrmSMTPController.php b/classes/controllers/FrmSMTPController.php
index be9d5dbad7..cd1ce97fb7 100644
--- a/classes/controllers/FrmSMTPController.php
+++ b/classes/controllers/FrmSMTPController.php
@@ -246,15 +246,14 @@ protected function output_section_step_install() {
 				<div>
 					<h2>%2$s</h2>
 					<p>%3$s</p>
-					<span><a rel="%4$s" class="button button-primary frm-button-primary %5$s" aria-label="%6$s">%7$s</a></span>
-				</div>		
+					<span><a rel="%4$s" class="button button-primary frm-button-primary %5$s">%6$s</a></span>
+				</div>
 			</section>',
 			FrmAppHelper::kses( $icon, array( 'a', 'i', 'span', 'use', 'svg' ) ), // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
 			esc_html( $label ),
 			esc_html__( 'Install WP Mail SMTP from the WordPress.org plugin repository.', 'formidable' ),
 			esc_attr( $step['plugin'] ),
 			esc_attr( $step['button_class'] ),
-			esc_attr( $step['button_action'] ),
 			esc_html( $step['button_text'] )
 		);
 	}
@@ -321,18 +320,16 @@ protected function get_data_step_install() {
 		$this->output_data['plugin_setup']         = false;
 
 		$step = array(
-			'icon'          => 'frm_step1_icon',
-			'button_action' => '',
+			'icon' => 'frm_step1_icon',
 		);
 
 		$is_installed = $this->output_data['plugin_installed'] || $this->output_data['pro_plugin_installed'];
 
 		if ( ! $is_installed ) {
 			// Return the download url.
-			$step['button_text']   = __( 'Install WP Mail SMTP', 'formidable' );
-			$step['button_class']  = 'frm-install-addon';
-			$step['button_action'] = __( 'Install', 'formidable' );
-			$step['plugin']        = $this->config['lite_download_url'];
+			$step['button_text']  = __( 'Install WP Mail SMTP', 'formidable' );
+			$step['button_class'] = 'frm-install-addon';
+			$step['plugin']       = $this->config['lite_download_url'];
 			return $step;
 		}
 
@@ -346,9 +343,8 @@ protected function get_data_step_install() {
 			$step['button_text']  = __( 'WP Mail SMTP Installed & Activated', 'formidable' );
 			$step['button_class'] = 'grey disabled';
 		} else {
-			$step['button_text']   = __( 'Activate WP Mail SMTP', 'formidable' );
-			$step['button_class']  = 'frm-activate-addon';
-			$step['button_action'] = __( 'Activate', 'formidable' );
+			$step['button_text']  = __( 'Activate WP Mail SMTP', 'formidable' );
+			$step['button_class'] = 'frm-activate-addon';
 		}
 
 		return $step;

From cffd748e2ed221a0b03a64dfea6c45e3ca3a6a75 Mon Sep 17 00:00:00 2001
From: "vivi-the-going-merry[bot]"
 <308115520+vivi-the-going-merry[bot]@users.noreply.github.com>
Date: Sat, 26 Sep 2026 05:43:51 -0600
Subject: [PATCH 2/2] Remove invalid aria-label on form-migrator install link

Same aria_attribute_valid violation as the SMTP page fix in this PR,
flagged as a non-blocking sibling instance during review:
FrmFormMigratorsHelper::install_button()'s not-installed branch renders
an <a> with no href/role and an aria-label, which is invalid for its
implicit "generic" role. The button's own visible text ("Get Started" /
"Install <Name> Importer") already conveys purpose.

Verified with IBM's accessibility-checker CLI against the rendered
markup directly (install_button() invoked via reflection, both
installed/not-installed branches): aria_attribute_valid violation count
drops from 1 to 0 with no other rule's count changing.
---
 classes/helpers/FrmFormMigratorsHelper.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/classes/helpers/FrmFormMigratorsHelper.php b/classes/helpers/FrmFormMigratorsHelper.php
index 7f6ba6b201..c9dde2e3ce 100644
--- a/classes/helpers/FrmFormMigratorsHelper.php
+++ b/classes/helpers/FrmFormMigratorsHelper.php
@@ -165,7 +165,7 @@ private static function install_button( $install, $label = '' ) {
 			}
 		} else {
 			?>
-			<a rel="<?php echo esc_attr( $install['package'] ); ?>" class="frm-install-addon button <?php echo esc_attr( $primary ); ?>" aria-label="<?php esc_attr_e( 'Install', 'formidable' ); ?>"><?php // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong ?>
+			<a rel="<?php echo esc_attr( $install['package'] ); ?>" class="frm-install-addon button <?php echo esc_attr( $primary ); ?>"><?php // phpcs:ignore SlevomatCodingStandard.Files.LineLength.LineTooLong ?>
 			<?php
 			if ( $label === 'auto' ) {
 				/* translators: %s: Name of the plugin */