From 157789080b5ad08e3547c8b80e265f9690558091 Mon Sep 17 00:00:00 2001 From: jdalton Date: Sat, 11 Jul 2026 15:23:39 -0400 Subject: [PATCH] refactor(scripts): inline Socket-override check in update-manifest isBlessedPackageName is being retired from @socketsecurity/lib (Socket packages no longer get special treatment in scanning); this script was its last importer. The engines-source decision here only distinguishes Socket-maintained @socketregistry/* overrides from third-party extensions, so inline that narrower check. --- scripts/npm/update-manifest.mts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/scripts/npm/update-manifest.mts b/scripts/npm/update-manifest.mts index 20ef709d5..95cd89cf5 100644 --- a/scripts/npm/update-manifest.mts +++ b/scripts/npm/update-manifest.mts @@ -20,7 +20,6 @@ import { biomeFormat } from '../repo/util/biome.mts' import { getModifiedFiles } from '../repo/util/git.mts' import { fetchPackageManifest } from '@socketsecurity/lib-stable/packages/manifest' import { resolveOriginalPackageName } from '@socketsecurity/lib-stable/packages/normalize' -import { isBlessedPackageName } from '@socketsecurity/lib-stable/packages/validation' import { resolvePackageJsonEntryExports } from '@socketsecurity/lib-stable/packages/exports' import { readPackageJson } from '@socketsecurity/lib-stable/packages/read' import { extractPackage } from '@socketsecurity/lib-stable/packages/tarball' @@ -85,7 +84,10 @@ export async function addNpmManifestData(manifest, options) { await extractPackage(nmPkgId, async nmPkgPath => { nmPkgJson = await readPackageJson(nmPkgPath, { normalize: true }) }) - const isBlessed = isBlessedPackageName(data.name) + // Socket-maintained overrides take engines from the published + // package.json; third-party extensions keep the manifest's engines. + // (Inlined from the retired isBlessedPackageName helper.) + const isSocketOverride = data.name.startsWith('@socketregistry/') manifestData.push([ PackageURL.fromString( `pkg:${eco}/${data.name}@${nmPkgJson.version}`, @@ -93,7 +95,9 @@ export async function addNpmManifestData(manifest, options) { { categories: nmPkgJson.socket?.categories ?? data.categories, engines: filterEngines( - isBlessed ? (nmPkgJson.engines ?? data.engines) : data.engines, + isSocketOverride + ? (nmPkgJson.engines ?? data.engines) + : data.engines, ), interop: data.interop, license: nmPkgJson.license ?? data.license,