159 fail build tool on err (#160)

* Propagate error to build tools

Author: cuzfrog

annotation/pom.xml

@@ -4,7 +4,7 @@
     <parent>
         <groupId>online.sharedtype</groupId>
         <artifactId>sharedtype-parent</artifactId>
-        <version>0.14.0-SNAPSHOT</version>
+        <version>0.13.2-SNAPSHOT</version>
         <relativePath>../pom.xml</relativePath>
     </parent>
 

build-tool-plugins/exec/pom.xml

@@ -5,12 +5,12 @@
     <parent>
         <groupId>online.sharedtype</groupId>
         <artifactId>sharedtype-parent</artifactId>
-        <version>0.14.0-SNAPSHOT</version>
+        <version>0.13.2-SNAPSHOT</version>
         <relativePath>../../pom.xml</relativePath>
     </parent>
 
     <artifactId>sharedtype-ap-exec</artifactId>
-    <version>0.14.0-SNAPSHOT</version>
+    <version>0.13.2-SNAPSHOT</version>
     <name>SharedType Annotation Processor Executor</name>
     <description>Call javac to execute annotation processing.</description>
 

build-tool-plugins/exec/src/main/java/online/sharedtype/exec/common/AnnotationProcessorExecutor.java

@@ -33,7 +33,8 @@ public AnnotationProcessorExecutor(Processor processor, Logger log, DependencyRe
         this.dependencyResolver = dependencyResolver;
     }
 
-    public void execute(Path projectBaseDir,
+    /** @return true if successful; false otherwise.  */
+    public boolean execute(Path projectBaseDir,
                         Path outputDir,
                         Iterable<Path> compileSourceRoots,
                         String sourceEncoding,
@@ -52,7 +53,7 @@ public void execute(Path projectBaseDir,
 
             JavaCompiler.CompilationTask task = compiler.getTask(logger, fileManager, diagnosticListener, compilerOptions, null, sources);
             task.setProcessors(Collections.singleton(processor));
-            task.call();
+            return task.call();
         }
     }
 

build-tool-plugins/gradle-plugin/gradle.properties

@@ -1,3 +1,3 @@
-version=0.14.0-SNAPSHOT
+version=0.13.2-SNAPSHOT
 mavenCentralPublishing=true
 signAllPublications=true

build-tool-plugins/gradle-plugin/it/gradle.properties

@@ -1 +1 @@
-projectVersion=0.14.0-SNAPSHOT
+projectVersion=0.13.2-SNAPSHOT

build-tool-plugins/gradle-plugin/src/main/java/online/sharedtype/gradle/SharedtypeGenTask.java

@@ -36,14 +36,18 @@ void setExtension(SharedtypeConfigExtension extension) {
 
     @TaskAction
     void action() {
+        boolean success;
         try {
-            execute();
+            success = execute();
         } catch (Exception e) {
             throw new SharedTypeException(String.format("Failed to execute task '%s'", TASK_NAME), e);
         }
+        if (!success) {
+            throw new SharedTypeException(String.format("Failed to execute task '%s'", TASK_NAME));
+        }
     }
 
-    private void execute() throws Exception {
+    private boolean execute() throws Exception {
         JavaPluginExtension javaPluginExtension = project.getExtensions().findByType(JavaPluginExtension.class);
         if (javaPluginExtension == null) {
             throw new UnsupportedOperationException("Could not find JavaPluginExtension, only Java projects are supported.");
@@ -67,7 +71,7 @@ private void execute() throws Exception {
             () -> classpathDependencies
         );
 
-        executor.execute(
+        return executor.execute(
             project.getProjectDir().toPath(),
             resolveOutputDirectory().toPath(),
             sourceDirs,

build-tool-plugins/maven-plugin/it/pom.xml

@@ -5,7 +5,7 @@
     <parent>
         <groupId>online.sharedtype</groupId>
         <artifactId>sharedtype-parent</artifactId>
-        <version>0.14.0-SNAPSHOT</version>
+        <version>0.13.2-SNAPSHOT</version>
         <relativePath>../../../pom.xml</relativePath>
     </parent>
 

build-tool-plugins/maven-plugin/pom.xml

@@ -5,12 +5,12 @@
     <parent>
         <groupId>online.sharedtype</groupId>
         <artifactId>sharedtype-parent</artifactId>
-        <version>0.14.0-SNAPSHOT</version>
+        <version>0.13.2-SNAPSHOT</version>
         <relativePath>../../pom.xml</relativePath>
     </parent>
 
     <artifactId>sharedtype-maven-plugin</artifactId>
-    <version>0.14.0-SNAPSHOT</version>
+    <version>0.13.2-SNAPSHOT</version>
     <packaging>maven-plugin</packaging>
     <name>SharedType Maven Plugin</name>
 

build-tool-plugins/maven-plugin/src/main/java/online/sharedtype/maven/SharedTypeGenMojo.java

@@ -5,6 +5,7 @@
 import online.sharedtype.exec.common.SharedTypeApCompilerOptions;
 import online.sharedtype.processor.SharedTypeAnnotationProcessor;
 import online.sharedtype.processor.support.annotation.Nullable;
+import online.sharedtype.processor.support.exception.SharedTypeException;
 import org.apache.maven.execution.MavenSession;
 import org.apache.maven.plugin.AbstractMojo;
 import org.apache.maven.plugin.MojoExecutionException;
@@ -64,13 +65,16 @@ public void execute() throws MojoExecutionException {
             new MavenDependencyResolver(repositorySystem, session, project)
         );
         try {
-            apExecutor.execute(
+            boolean success = apExecutor.execute(
                 project.getBasedir().toPath(),
                 Paths.get(outputDirectory),
                 project.getCompileSourceRoots().stream().map(Paths::get).collect(Collectors.toList()),
                 project.getProperties().getProperty(PROP_PROJECT_SOURCE_ENCODING),
                 new SharedTypeApCompilerOptions(propertyFile).toList()
             );
+            if (!success) {
+                throw new SharedTypeException("Some error during annotation processing.");
+            }
         } catch (Exception e) {
             throw new MojoExecutionException(e);
         }

doc/Development.md

@@ -111,4 +111,4 @@ To Test Javadoc locally:
 ```
 Then open `annotation/target/reports/apidocs/index.html`.
 
-To test deployment, see [release](../misc/release.sh).
+To test deployment, see scripts: [release](../misc/release.sh), [setversion](../misc/setversion.sh).