fix: scope custom role callback replacement to each role and script

Author: Elektryk-Andrzej

Code/Helpers/ExampleHandler.cs

@@ -7,6 +7,7 @@
 using SER.Code.MethodSystem;
 using SER.Code.MethodSystem.Structures;
 using SER.Code.MethodSystem.Methods.CustomRoleMethods.Structures;
+using SER.Code.MethodSystem.Methods.CustomRoleMethods;
 using SER.Code.ScriptSystem;
 using SER.Code.ScriptSystem.Structures;
 using SER.Code.TokenSystem;
@@ -385,26 +386,49 @@ public static (string?, string[]) Verify(string? projectDirectory = null)
             return null;
         }
 
-        const string handlerId = "custom-role handler audit";
+        var roleAId = CRole_SetCallbacksMethod.GetHandlerId("roleA", ScriptName.CreateUnsafe("role_callback_audit"));
+        var roleBId = CRole_SetCallbacksMethod.GetHandlerId("roleB", ScriptName.CreateUnsafe("role_callback_audit"));
+        var otherScriptId = CRole_SetCallbacksMethod.GetHandlerId("roleA", ScriptName.CreateUnsafe("other_callback_audit"));
+        var oldCalls = 0;
+        var replacementCalls = 0;
+        var roleBCalls = 0;
+        var otherScriptCalls = 0;
         var first = new CRole.Handler
         {
-            Id = handlerId,
-            Action = (_, _) => { }
+            Id = roleAId,
+            ForRoles = ["roleA"],
+            Action = (_, _) => oldCalls++
         };
         var replacement = new CRole.Handler
         {
-            Id = handlerId,
-            Action = (_, _) => { }
+            Id = roleAId,
+            ForRoles = ["roleA"],
+            Action = (_, _) => replacementCalls++
+        };
+        var roleB = new CRole.Handler
+        {
+            Id = roleBId,
+            ForRoles = ["roleB"],
+            Action = (_, _) => roleBCalls++
+        };
+        var otherScript = new CRole.Handler
+        {
+            Id = otherScriptId,
+            ForRoles = ["roleA"],
+            Action = (_, _) => otherScriptCalls++
         };
 
         try
         {
             CRole.AddOrReplaceHandler(CRole.CustomRoleEvent.Spawned, first);
+            CRole.AddOrReplaceHandler(CRole.CustomRoleEvent.Spawned, roleB);
+            CRole.AddOrReplaceHandler(CRole.CustomRoleEvent.Spawned, otherScript);
             CRole.AddOrReplaceHandler(CRole.CustomRoleEvent.Spawned, replacement);
-            return CRole.EventHandlers[CRole.CustomRoleEvent.Spawned] is { Count: 1 } handlers
-                   && ReferenceEquals(handlers.Single(), replacement)
-                ? null
-                : "Registering a custom-role callback twice left its stale handler active.";
+            var handlers = CRole.EventHandlers[CRole.CustomRoleEvent.Spawned];
+            foreach (var handler in handlers) handler.Action(null!, null!);
+            return handlers.Count == 3 && oldCalls == 0 && replacementCalls == 1
+                   && roleBCalls == 1 && otherScriptCalls == 1
+                ? null : "Replacing a custom-role callback lost another role or script's callback, or kept the stale handler.";
         }
         finally
         {

Code/MethodSystem/Methods/CustomRoleMethods/CRole_SetCallbacksMethod.cs

@@ -2,6 +2,7 @@
 using SER.Code.ArgumentSystem.BaseArguments;
 using SER.Code.MethodSystem.BaseMethods.Synchronous;
 using SER.Code.MethodSystem.Methods.CustomRoleMethods.Structures;
+using SER.Code.ScriptSystem.Structures;
 using SER.Code.ValueSystem;
 
 namespace SER.Code.MethodSystem.Methods.CustomRoleMethods;
@@ -11,7 +12,7 @@ namespace SER.Code.MethodSystem.Methods.CustomRoleMethods;
 public class CRole_SetCallbacksMethod : SynchronousMethod
 {
     public override string Description =>
-        "Sets the callbacks for a provided custom role. Calling it again from the same script replaces the previous callbacks.";
+        "Sets the callbacks for a provided custom role. Calling it again from the same script replaces that role's callbacks without changing callbacks for other roles.";
 
     public override Argument[] ExpectedArguments { get; } =
     [
@@ -53,9 +54,12 @@ CRole.Handler GetHandler(CallbackArgument.Callback callback)
             return new()
             {
                 Action = (plr, role) => callback.Action([new PlayerValue(plr), new ReferenceValue<CRole>(role)], null),
-                Id = $"callback '{callback.Name}' in script '{Script.Name}'",
+                Id = GetHandlerId(customRole.Id, Script.Name),
                 ForRoles = [customRole.Id]
             };
         }
     }
+
+    internal static string GetHandlerId(string roleId, ScriptName scriptName) =>
+        $"callbacks for custom role '{roleId}' in script '{scriptName}'";
 }

VS Code Extension/out/ser-language.json

@@ -10408,7 +10408,7 @@
     },
     "CRole.SetCallbacks": {
       "syntax": "CRole.SetCallbacks custom_role on_spawning? on_removing?",
-      "description": "Sets the callbacks for a provided custom role. Calling it again from the same script replaces the previous callbacks.",
+      "description": "Sets the callbacks for a provided custom role. Calling it again from the same script replaces that role's callbacks without changing callbacks for other roles.",
       "subgroup": "CustomRole",
       "essential": false,
       "additionalDescription": null,

VS Code Extension/out/visual-editor.html

@@ -14049,7 +14049,7 @@ <h1 id="recipeTitle">What do you want to make?</h1>
     },
     "CRole.SetCallbacks": {
       "syntax": "CRole.SetCallbacks custom_role on_spawning? on_removing?",
-      "description": "Sets the callbacks for a provided custom role. Calling it again from the same script replaces the previous callbacks.",
+      "description": "Sets the callbacks for a provided custom role. Calling it again from the same script replaces that role's callbacks without changing callbacks for other roles.",
       "subgroup": "CustomRole",
       "essential": false,
       "additionalDescription": null,

website/data/ser-truth-table.json

@@ -10408,7 +10408,7 @@
     },
     "CRole.SetCallbacks": {
       "syntax": "CRole.SetCallbacks custom_role on_spawning? on_removing?",
-      "description": "Sets the callbacks for a provided custom role. Calling it again from the same script replaces the previous callbacks.",
+      "description": "Sets the callbacks for a provided custom role. Calling it again from the same script replaces that role's callbacks without changing callbacks for other roles.",
       "subgroup": "CustomRole",
       "essential": false,
       "additionalDescription": null,