uri templates will only work with key value pairs

Author: thefringeninja

src/SqlStreamStore.HAL.Tests/AllStreamMessageTests.cs

@@ -15,7 +15,7 @@ public AllStreamMessageTests()
 
         public void Dispose() => _fixture.Dispose();
         private readonly SqlStreamStoreHalMiddlewareFixture _fixture;
-        private const string HeadOfAll = "../stream?d=b&m=20&p=-1";
+        private const string HeadOfAll = "../stream?d=b&m=20&p=-1&e=0";
 
         [Fact]
         public async Task read_single_message_all_stream()

src/SqlStreamStore.HAL.Tests/CanonicalUrlTests.cs

@@ -31,7 +31,7 @@ IEnumerable<string[]> GetPermutations(string[] items, int length)
 
             var d = $"d={(forward ? 'f' : 'b')}";
             var m = "m=20";
-            var e = prefetch ? "e" : null;
+            var e = $"e={(prefetch ? '1' : '0')}";
             var p = "p=0";
 
             var parameters = new[]

src/SqlStreamStore.HAL.Tests/StreamMessageTests.cs

@@ -15,7 +15,7 @@ public StreamMessageTests()
 
         public void Dispose() => _fixture.Dispose();
         private readonly SqlStreamStoreHalMiddlewareFixture _fixture;
-        private const string HeadOfStream = "../a-stream?d=b&m=20&p=-1";
+        private const string HeadOfStream = "../a-stream?d=b&m=20&p=-1&e=0";
 
         [Fact]
         public async Task read_single_message_stream()

src/SqlStreamStore.HAL.Tests/StreamNavigationTests.cs

@@ -10,8 +10,8 @@
 
     public class StreamNavigationTests : IDisposable
     {
-        private const string FirstLinkQuery = "d=f&m=20&p=0";
-        private const string LastLinkQuery = "d=b&m=20&p=-1";
+        private const string FirstLinkQuery = "d=f&m=20&p=0&e=0";
+        private const string LastLinkQuery = "d=b&m=20&p=-1&e=0";
 
         private readonly SqlStreamStoreHalMiddlewareFixture _fixture;
 
@@ -81,7 +81,7 @@ await _fixture.HttpClient.GetAsync($"{baseAddress}{firstResponse.Headers.Locatio
 
                     resource.ShouldLink(Constants.Relations.Last, $"{stream}?{LastLinkQuery}");
 
-                    resource.ShouldLink(Constants.Relations.Previous, $"{stream}?d=b&m=20&p=9");
+                    resource.ShouldLink(Constants.Relations.Previous, $"{stream}?d=b&m=20&p=9&e=0");
 
                     resource.ShouldLink(Constants.Relations.First, $"{stream}?{FirstLinkQuery}");
 
@@ -136,7 +136,7 @@ public async Task read_first_link_when_multiple_pages(string stream, string base
 
                 resource.ShouldLink(Constants.Relations.Last, $"{stream}?{LastLinkQuery}");
 
-                resource.ShouldLink(Constants.Relations.Next, $"{stream}?d=f&m=20&p=20");
+                resource.ShouldLink(Constants.Relations.Next, $"{stream}?d=f&m=20&p=20&e=0");
 
                 resource.ShouldLink(Constants.Relations.First, $"{stream}?{FirstLinkQuery}");
 

src/SqlStreamStore.HAL/Resources/LinkFormatter.cs

@@ -3,7 +3,7 @@ namespace SqlStreamStore.HAL.Resources
     internal static class LinkFormatter
     {
         private static string FormatLink(string baseAddress, string direction, int maxCount, long position, bool prefetch)
-            => $"{baseAddress}?d={direction}&m={maxCount}&p={position}{(prefetch ? "&e" : string.Empty)}";
+            => $"{baseAddress}?d={direction}&m={maxCount}&p={position}&e={(prefetch ? 1 : 0)}";
 
         public static string FormatForwardLink(string baseAddress, int maxCount, long position, bool prefetch)
             => FormatLink(baseAddress, "f", maxCount, position, prefetch);

src/SqlStreamStore.HAL/Resources/ReadAllStreamOperation.cs

@@ -12,7 +12,8 @@ internal class ReadAllStreamOperation : IStreamStoreOperation<ReadAllPage>
 
         public ReadAllStreamOperation(HttpRequest request)
         {
-            EmbedPayload = request.Query.TryGetValueCaseInsensitive('e', out _);
+            EmbedPayload = request.Query.TryGetValueCaseInsensitive('e', out var embedPayload)
+                           && embedPayload == "1";
 
             ReadDirection = request.Query.TryGetValueCaseInsensitive('d', out var readDirection)
                             && readDirection == "f" || readDirection == "F"

src/SqlStreamStore.HAL/Resources/ReadStreamOperation.cs

@@ -14,7 +14,8 @@ public ReadStreamOperation(HttpRequest request)
         {
             StreamId = request.Path.Value.Remove(0, 1);
 
-            EmbedPayload = request.Query.TryGetValueCaseInsensitive('e', out _);
+            EmbedPayload = request.Query.TryGetValueCaseInsensitive('e', out var embedPayload)
+                           && embedPayload == "1";
 
             ReadDirection = request.Query.TryGetValueCaseInsensitive('d', out var readDirection)
                             && readDirection == "f" || readDirection == "F"