better logging

Author: thefringeninja

src/KestrelPureOwin/KestrelOwinServer.cs

@@ -49,8 +49,9 @@ public KestrelOwinServer(KestrelServerOptions options)
             }
 
             var wrappedOptions = Options.Create(options);
-
+            
             var loggerFactory = new LoggerFactory();
+            loggerFactory.AddProvider(new ConsoleLogProvider());
 
             var transport = new LibuvTransportFactory(
                 Options.Create(new LibuvTransportOptions()),
@@ -65,18 +66,6 @@ private static KestrelServerOptions GetOptions(IDictionary<string, object> prope
 
         public KestrelServer Server { get; }
 
-        public Task Run(string url, Action<BuildFunc> configure, CancellationToken cancellationToken)
-        {
-            Console.CancelKeyPress += (s, e) =>
-            {
-                Console.WriteLine("Application is shutting down...");
-
-                e.Cancel = true;
-            };
-
-            return Start(url, configure, cancellationToken);
-        }
-
         public Task Start(string url, Action<BuildFunc> configure, CancellationToken cancellationToken)
         {
             var application = ConfigureApplication(configure);
@@ -119,5 +108,32 @@ private static OwinApplication BuildApplication(IEnumerable<MidFunc> middleware)
 
             return new OwinApplication(app);
         }
+
+        private class ConsoleLogger : ILogger
+        {
+            public void Log<TState>(LogLevel logLevel, EventId eventId, TState state, Exception exception, Func<TState, Exception, string> formatter) 
+                => Console.WriteLine(formatter(state, exception));
+
+            public bool IsEnabled(LogLevel logLevel) => true;
+
+            public IDisposable BeginScope<TState>(TState state) => new NoOpScope();
+            
+            private class NoOpScope : IDisposable
+            {
+                public void Dispose()
+                {
+                }
+            }
+        }
+
+        private class ConsoleLogProvider : ILoggerProvider
+        {
+            public void Dispose()
+            {
+                
+            }
+
+            public ILogger CreateLogger(string categoryName) => new ConsoleLogger();
+        }
     }
 }

src/SqlStreamStore.HAL.DevServer/Program.cs

@@ -59,13 +59,17 @@ private static Action<BuildFunc> Configure(IStreamStore streamStore)
                 .Use(DisplayErrors)
                 .Use(SqlStreamStoreHalMiddleware.UseSqlStreamStoreHal(streamStore));
 
-        private static MidFunc DisplayErrors => next => env => next(env).ContinueWith(_ =>
+        private static MidFunc DisplayErrors => next => async env =>
+        {
+            try
+            {
+                await next(env);
+            }
+            catch(Exception ex)
             {
-                Console.WriteLine(_.Exception);
-                
-                return Task.CompletedTask;
-            },
-            TaskContinuationOptions.OnlyOnFaulted);
+                Console.WriteLine(ex);    
+            }
+        };
 
         private static void DisplayMenu(IStreamStore streamStore)
         {

src/SqlStreamStore.HAL/StreamResource.cs

@@ -72,7 +72,6 @@ public async Task<Response> GetMessage(
                 };
             }
 
-
             var payload = await message.GetJsonData(cancellationToken);
 
             return new Response(