Merge pull request #31 from thefringeninja/204

Delete Operations Should Return No Content

Author: thefringeninja

src/SqlStreamStore.HAL.Tests/StreamDeleteTests.cs

@@ -33,7 +33,7 @@ public async Task expected_version(int? expectedVersion)
 
             using(var response = await _fixture.HttpClient.SendAsync(request))
             {
-                response.StatusCode.ShouldBe(HttpStatusCode.OK);                
+                response.StatusCode.ShouldBe(HttpStatusCode.NoContent);                
             }
 
             var page = await _fixture.StreamStore.ReadStreamForwards(StreamId, 0, 1);

src/SqlStreamStore.HAL.Tests/StreamMessageTests.cs

@@ -72,7 +72,7 @@ public async Task delete_single_message_by_version()
 
             using(var response = await _fixture.HttpClient.DeleteAsync("/streams/a-stream/0"))
             {
-                response.StatusCode.ShouldBe(HttpStatusCode.OK);
+                response.StatusCode.ShouldBe(HttpStatusCode.NoContent);
             }
 
             using(var response = await _fixture.HttpClient.GetAsync("/streams/a-stream/0"))

src/SqlStreamStore.HAL/NoContentResponse.cs

@@ -0,0 +1,18 @@
+namespace SqlStreamStore.HAL
+{
+    using System.Threading;
+    using System.Threading.Tasks;
+    using Microsoft.AspNetCore.Http;
+
+    internal class NoContentResponse : Response
+    {
+        public static readonly NoContentResponse Instance = new NoContentResponse();
+
+        private NoContentResponse()
+            : base(204)
+        { }
+
+        public override Task WriteBody(HttpResponse response, CancellationToken cancellationToken)
+            => Task.CompletedTask;
+    }
+}

src/SqlStreamStore.HAL/Response.cs

@@ -11,6 +11,10 @@ internal abstract class Response
         public int StatusCode { get; }
         public IDictionary<string, string[]> Headers { get; }
 
+        protected Response(int statusCode)
+            : this(statusCode, null)
+        { }
+
         protected Response(int statusCode, string mediaType)
         {
             StatusCode = statusCode;

src/SqlStreamStore.HAL/StreamMessage/StreamMessageResource.cs

@@ -91,8 +91,7 @@ public async Task<Response> Delete(
         {
             await operation.Invoke(_streamStore, cancellationToken);
 
-            return new HalJsonResponse(
-                new HALResponse(new HALModelConfig()));
+            return NoContentResponse.Instance;
         }
     }
 }

src/SqlStreamStore.HAL/Streams/StreamResource.cs

@@ -130,7 +130,7 @@ public async Task<Response> Delete(DeleteStreamOperation operation, Cancellation
         {
             await operation.Invoke(_streamStore, cancellationToken);
 
-            return new HalJsonResponse(new HALResponse(new object()));
+            return NoContentResponse.Instance;
         }
     }
 }