forgot that NoStream is -1

Author: thefringeninja

src/SqlStreamStore.HAL.Tests/StreamAppendTests.cs

@@ -6,7 +6,6 @@
     using System.Net;
     using System.Net.Http;
     using System.Net.Http.Headers;
-    using System.Reflection;
     using System.Threading.Tasks;
     using Newtonsoft.Json.Linq;
     using Shouldly;
@@ -285,17 +284,12 @@ public static IEnumerable<object[]> BadExpectedVersionCases()
         {
             var random = new Random();
 
-            var minimum = (from fieldInfo in typeof(ExpectedVersion)
-                                  .GetFields(BindingFlags.Public | BindingFlags.Static | BindingFlags.FlattenHierarchy)
-                              where fieldInfo.IsLiteral
-                                    && !fieldInfo.IsInitOnly
-                                    && fieldInfo.FieldType == typeof(int)
-                              select (int) fieldInfo.GetRawConstantValue()).Min() - 1;
+            var maximumBadExpectedVersion = Constants.Headers.MinimumExpectedVersion - 1;
 
-            yield return new object[] { minimum };
+            yield return new object[] { maximumBadExpectedVersion };
             for(var i = 0; i < 5; i++)
             {
-                yield return new object[] { random.Next(int.MinValue, minimum) };
+                yield return new object[] { random.Next(int.MinValue, maximumBadExpectedVersion) };
             }
         }
 

src/SqlStreamStore.HAL/Constants.cs

@@ -1,6 +1,9 @@
 namespace SqlStreamStore.HAL
 {
+    using System.Linq;
+    using System.Reflection;
     using Microsoft.AspNetCore.Http;
+    using SqlStreamStore.Streams;
 
     internal static class Constants
     {
@@ -13,6 +16,13 @@ public static class MediaTypes
 
         public static class Headers
         {
+            public static int MinimumExpectedVersion = (from fieldInfo in typeof(ExpectedVersion)
+                    .GetFields(BindingFlags.Public | BindingFlags.Static | BindingFlags.FlattenHierarchy)
+                where fieldInfo.IsLiteral
+                      && !fieldInfo.IsInitOnly
+                      && fieldInfo.FieldType == typeof(int)
+                select (int) fieldInfo.GetRawConstantValue()).Min();
+
             public const string ExpectedVersion = "SSS-ExpectedVersion";
             public const string HeadPosition = "SSS-HeadPosition";
             public const string Location = "Location";

src/SqlStreamStore.HAL/Streams/StreamResource.cs

@@ -29,7 +29,7 @@ public async Task<Response> Post(
             AppendStreamOperation operation,
             CancellationToken cancellationToken)
         {
-            if(operation.ExpectedVersion < ExpectedVersion.NoStream)
+            if(operation.ExpectedVersion < Constants.Headers.MinimumExpectedVersion)
             {
                 return new HalJsonResponse(new HALResponse(new
                 {