newtonsoft json 10 supports async properly so there is no need to buffer this in memory

Author: thefringeninja

src/SqlStreamStore.HAL.Tests/packages.config

@@ -3,16 +3,18 @@ namespace SqlStreamStore.HAL
     using System.IO;
     using System.Threading.Tasks;
     using Halcyon.HAL;
-    using Microsoft.IO;
     using Microsoft.Owin;
     using Newtonsoft.Json;
     using Newtonsoft.Json.Serialization;
     using SqlStreamStore.Streams;
 
     internal static class OwinContextExtensions
     {
-        private static readonly RecyclableMemoryStreamManager s_StreamManager
-            = new RecyclableMemoryStreamManager();
+        private static readonly JsonSerializer s_serializer = JsonSerializer.Create(new JsonSerializerSettings
+        {
+            ContractResolver = new CamelCasePropertyNamesContractResolver(),
+            TypeNameHandling = TypeNameHandling.None
+        });
 
         public static async Task WriteHalResponse(this IOwinContext context, Response response)
         {
@@ -25,24 +27,14 @@ public static async Task WriteHalResponse(this IOwinContext context, Response re
                 context.Response.Headers.AppendValues(header.Key, header.Value);
             }
 
-            using(var stream = s_StreamManager.GetStream())
-            using(var writer = new StreamWriter(stream))
+            using(var writer = new JsonTextWriter(new StreamWriter(context.Response.Body))
             {
-                using(var jwriter = new JsonTextWriter(writer) { CloseOutput = false })
-                {
-                    var serializer = new JsonSerializer
-                    {
-                        ContractResolver = new CamelCasePropertyNamesContractResolver()
-                    };
-
-                    serializer.Serialize(jwriter, response.Hal);
-
-                    jwriter.Flush();
-                }
-
-                stream.Position = 0;
+                CloseOutput = false
+            })
+            {
+                await response.Hal.ToJObject(s_serializer).WriteToAsync(writer, context.Request.CallCancelled);
 
-                await stream.CopyToAsync(context.Response.Body, 8192, context.Request.CallCancelled);
+                await writer.FlushAsync(context.Request.CallCancelled);
             }
         }
 

src/SqlStreamStore.HAL/OwinContextExtensions.cs

@@ -22,7 +22,6 @@
     <PackageReference Include="KatanaNetStandard" Version="3.0.7" />
     <PackageReference Include="LibLog" Version="4.2.6" PrivateAssets="All" />
     <PackageReference Include="Microsoft.CSharp" Version="4.4.0" />
-    <PackageReference Include="Microsoft.IO.RecyclableMemoryStream" Version="1.2.2" />
     <PackageReference Include="Newtonsoft.Json" Version="10.0.3" />
     <PackageReference Include="SqlStreamStore" Version="1.1.0" />
     <PackageReference Include="Tavis.UriTemplates" Version="1.1.1" />