goodbye tuples

Author: thefringeninja

src/SqlStreamStore.HAL.Tests/HttpResponseMessageExtensions.cs

@@ -19,7 +19,7 @@ public static async Task<Resource> AsHal(this HttpResponseMessage response)
         private static Resource ParseResource(JObject outer)
         {
             var links = new List<Link>();
-            var embedded = new List<Tuple<string, Resource>>();
+            var embedded = new List<(string, Resource)>();
             var state = new JObject();
 
             foreach(var inner in outer.Properties())
@@ -67,8 +67,8 @@ private static Resource ParseResource(JObject outer)
             return new Resource(state, links.ToArray(), embedded.ToArray());
         }
 
-        private static Tuple<string, Resource> ParseEmbeddedResource(JObject outer, string rel)
-            => Tuple.Create(rel, ParseResource(outer));
+        private static (string, Resource) ParseEmbeddedResource(JObject outer, string rel)
+            => (rel, ParseResource(outer));
 
         private static Link ParseLink(JObject outer, string rel)
         {

src/SqlStreamStore.HAL.Tests/Resource.cs

@@ -1,16 +1,15 @@
 namespace SqlStreamStore.HAL.Tests
 {
-    using System;
     using System.Collections.Generic;
     using System.Linq;
 
     internal class Resource
     {
-        public Resource(dynamic state, Link[] links, Tuple<string, Resource>[] embedded)
+        public Resource(dynamic state, Link[] links, (string rel, Resource resource)[] embedded)
         {
             State = state;
             Links = links.GroupBy(l => l.Rel).ToDictionary(g => g.Key, g => g.ToArray());
-            Embedded = embedded.GroupBy(e => e.Item1).ToDictionary(g => g.Key, g => g.Select(e => e.Item2).ToArray());
+            Embedded = embedded.GroupBy(e => e.rel).ToDictionary(g => g.Key, g => g.Select(e => e.resource).ToArray());
         }
 
         public dynamic State { get; }

src/SqlStreamStore.HAL/SqlStreamStore.HAL.csproj

@@ -16,6 +16,7 @@
     <NoWarn>1701;1702;1705;1591</NoWarn>
   </PropertyGroup>
   <ItemGroup>
+    <PackageReference Include="System.ValueTuple" Version="4.3.0" />
     <PackageReference Include="Halcyon" Version="2.5.1" />
     <PackageReference Include="LibLog" Version="4.2.6" PrivateAssets="All" />
     <PackageReference Include="Microsoft.IO.RecyclableMemoryStream" Version="1.2.2" />