setting the reason phrase from one place

Author: thefringeninja

src/SqlStreamStore.HAL/AppendStreamMiddleware.cs

@@ -40,12 +40,6 @@ private static MidFunc AppendStream(StreamResource stream) => next => async env
             {
                 var response = await stream.AppendMessages(options, context.Request.CallCancelled);
 
-                if(response.StatusCode == 201)
-                {
-                    context.Response.ReasonPhrase = "Created";
-                    context.Response.Headers["Location"] = $"streams/{options.StreamId}";
-                }
-
                 await context.WriteHalResponse(response);
             }
             catch(WrongExpectedVersionException ex)

src/SqlStreamStore.HAL/Constants.cs

@@ -1,5 +1,8 @@
 namespace SqlStreamStore.HAL
 {
+    using System.Collections.Generic;
+    using System.Collections.ObjectModel;
+
     internal static class Constants
     {
         public static class Headers
@@ -12,5 +15,17 @@ public static class ContentTypes
                 public const string Json = "application/json";
             }
         }
+        
+        public static IReadOnlyDictionary<int, string> ReasonPhrases { get; }
+            = new ReadOnlyDictionary<int, string>(new Dictionary<int, string>
+            {
+                [200] = "OK",
+                [201] = "Created",
+                [307] = "Moved Temporarily",
+                [400] = "Bad Request",
+                [404] = "Not Found",
+                [405] = "Method Not Allowed",
+                [409] = "Conflict"
+            });
     }
 }

src/SqlStreamStore.HAL/OwinContextExtensions.cs

@@ -68,6 +68,11 @@ public static async Task WriteHalResponse(this IOwinContext context, Response re
 
             context.Response.StatusCode = response.StatusCode;
 
+            foreach(var header in response.Headers)
+            {
+                context.Response.Headers.AppendValues(header.Key, header.Value);
+            }
+
             using(var stream = s_StreamManager.GetStream())
             using(var writer = new StreamWriter(stream))
             {
@@ -92,7 +97,6 @@ public static async Task WriteHalResponse(this IOwinContext context, Response re
         public static Task WriteProblemDetailsResponse(this IOwinContext context, WrongExpectedVersionException ex)
         {
             context.Response.StatusCode = 409;
-            context.Response.ReasonPhrase = "Conflict";
             context.Response.ContentType = Constants.Headers.ContentTypes.ProblemDetails;
 
             return context.Response.WriteAsync(ex.ConvertToProblemDetails(), context.Request.CallCancelled);

src/SqlStreamStore.HAL/ReadStreamMiddleware.cs

@@ -59,7 +59,6 @@ private static MidFunc GetStreamMessage(StreamResource stream) => next => async
             if(options.StreamVersion == StreamVersion.End)
             {
                 context.Response.StatusCode = 307;
-                context.Response.ReasonPhrase = "Moved Temporarily";
                 context.Response.Headers["Location"] = $"{((dynamic) response.Hal.Model).StreamVersion}";
 
                 return;

src/SqlStreamStore.HAL/Response.cs

@@ -1,16 +1,19 @@
 namespace SqlStreamStore.HAL
 {
+    using System.Collections.Generic;
     using Halcyon.HAL;
 
     public class Response
     {
         public HALResponse Hal { get; }
         public int StatusCode { get; }
+        public IDictionary<string, string[]> Headers { get; }
 
         public Response(HALResponse hal, int statusCode = 200)
         {
             Hal = hal;
             StatusCode = statusCode;
+            Headers = new Dictionary<string, string[]>();
         }
     }
 }

src/SqlStreamStore.HAL/SqlStreamStoreHalMiddleware.cs

@@ -21,7 +21,7 @@ public static class SqlStreamStoreHalMiddleware
 
             context.Response.OnSendingHeaders(_ =>
                 {
-                    context.Response.Headers["Access-Control-Allow-Methods"] = "GET, OPTIONS";
+                    context.Response.Headers["Access-Control-Allow-Methods"] = "GET, HEAD, OPTIONS";
                     context.Response.Headers["Access-Control-Allow-Headers"]
                         = "Content-Type, X-Requested-With, Authorization";
                     context.Response.Headers["Access-Control-Allow-Origin"] = "*";
@@ -31,6 +31,24 @@ public static class SqlStreamStoreHalMiddleware
             return next(env);
         };
 
+        private static MidFunc AddReasonPhrase => next => env =>
+        {
+            var context = new OwinContext(env);
+
+            context.Response.OnSendingHeaders(_ =>
+                {
+                    if(!Constants.ReasonPhrases.TryGetValue(context.Response.StatusCode, out var reasonPhrase))
+                    {
+                        return;
+                    }
+
+                    context.Response.ReasonPhrase = reasonPhrase;
+                },
+                null);
+
+            return next(env);
+        };
+
         private static MidFunc Index => next => env =>
         {
             var context = new OwinContext(env);
@@ -52,6 +70,7 @@ public static MidFunc UseSqlStreamStoreHal(IStreamStore streamStore)
 
             var builder = new AppBuilder()
                 .Use(AccessControl)
+                .Use(AddReasonPhrase)
                 .Use(Index)
                 .Map("/stream", inner => inner
                     .Use(ReadAllStreamMiddleware.UseStreamStore(streamStore))
@@ -81,7 +100,6 @@ private static MidFunc MethodsNotAllowed(params string[] methods)
                 }
 
                 context.Response.StatusCode = 405;
-                context.Response.ReasonPhrase = "Method Not Allowed";
 
                 return Task.CompletedTask;
             };

src/SqlStreamStore.HAL/StreamResource.cs

@@ -27,11 +27,16 @@ public async Task<Response> AppendMessages(
 
             var result = await operation.Invoke(_streamStore, cancellationToken);
 
-            return new Response(
+            var response = new Response(
                 new HALResponse(new object()),
                 options.ExpectedVersion == ExpectedVersion.NoStream
                     ? 201
                     : 200);
+            if(options.ExpectedVersion == ExpectedVersion.NoStream)
+            {
+                response.Headers["Location"] = new[] { $"streams/{options.StreamId}" };
+            }
+            return response;
         }
 
         public async Task<Response> GetMessage(