fixed inconsistent sorting

http client will have to re-order when reading backwards

Author: thefringeninja

src/SqlStreamStore.HAL/Resources/AllStreamResource.cs

@@ -32,7 +32,9 @@ public async Task<Response> GetPage(
         {
             var page = await operation.Invoke(_streamStore, cancellationToken);
 
-            var payloads = await Task.WhenAll(page.Messages
+            var streamMessages = page.Messages.OrderByDescending(m => m.Position).ToArray();
+
+            var payloads = await Task.WhenAll(streamMessages
                 .Select(message => operation.EmbedPayload
                     ? message.GetJsonData(cancellationToken)
                     : Task.FromResult<string>(null))
@@ -50,29 +52,30 @@ public async Task<Response> GetPage(
                     .AddLinks(Links.All.Feed(operation))
                     .AddEmbeddedCollection(
                         Constants.Relations.Message,
-                        page.Messages.Zip(payloads,
+                        streamMessages.Zip(
+                            payloads,
                             (message, payload) => new HALResponse(new
-                            {
-                                message.MessageId,
-                                message.CreatedUtc,
-                                message.Position,
-                                message.StreamId,
-                                message.StreamVersion,
-                                message.Type,
-                                payload,
-                                metadata = message.JsonMetadata
-                            }).AddLinks(
-                                Links.All.Self(message)))));
+                                {
+                                    message.MessageId,
+                                    message.CreatedUtc,
+                                    message.Position,
+                                    message.StreamId,
+                                    message.StreamVersion,
+                                    message.Type,
+                                    payload,
+                                    metadata = message.JsonMetadata
+                                })
+                                .AddLinks(Links.All.Self(message)))));
 
             if(operation.FromPositionInclusive == Position.End)
             {
-                var headPosition = page.Messages.Length > 0
-                    ? page.Messages[0].Position
+                var headPosition = streamMessages.Length > 0
+                    ? streamMessages[0].Position
                     : Position.End;
-                
+
                 response.Headers[Constants.Headers.HeadPosition] = new[] { $"{headPosition}" };
             }
-            
+
             return response;
         }
     }

src/SqlStreamStore.HAL/Resources/StreamResource.cs

@@ -45,14 +45,17 @@ public async Task<Response> AppendMessages(
             {
                 response.Headers[Constants.Headers.Location] = new[] { $"streams/{operation.StreamId}" };
             }
+
             return response;
         }
 
         public async Task<Response> GetPage(ReadStreamOperation operation, CancellationToken cancellationToken)
         {
             var page = await operation.Invoke(_streamStore, cancellationToken);
 
-            var payloads = await Task.WhenAll(page.Messages
+            var streamMessages = page.Messages.OrderByDescending(m => m.Position).ToArray();
+
+            var payloads = await Task.WhenAll(streamMessages
                 .Select(message => operation.EmbedPayload
                     ? message.GetJsonData(cancellationToken)
                     : Task.FromResult<string>(null))
@@ -73,25 +76,27 @@ public async Task<Response> GetPage(ReadStreamOperation operation, CancellationT
                     .AddLinks(Links.Stream.Metadata(operation))
                     .AddEmbeddedCollection(
                         Constants.Relations.Message,
-                        page.Messages.Zip(payloads,
+                        streamMessages.Zip(
+                            payloads,
                             (message, payload) => new HALResponse(new
-                            {
-                                message.MessageId,
-                                message.CreatedUtc,
-                                message.Position,
-                                message.StreamId,
-                                message.StreamVersion,
-                                message.Type,
-                                payload,
-                                metadata = message.JsonMetadata
-                            }).AddLinks(Links.StreamMessage.Self(message)))),
+                                {
+                                    message.MessageId,
+                                    message.CreatedUtc,
+                                    message.Position,
+                                    message.StreamId,
+                                    message.StreamVersion,
+                                    message.Type,
+                                    payload,
+                                    metadata = message.JsonMetadata
+                                })
+                                .AddLinks(Links.StreamMessage.Self(message)))),
                 page.Status == PageReadStatus.StreamNotFound ? 404 : 200);
         }
 
         public async Task<Response> Delete(DeleteStreamOperation operation, CancellationToken cancellationToken)
         {
             await operation.Invoke(_streamStore, cancellationToken);
-            
+
             return new Response(new HALResponse(new object()));
         }
     }