[BUG] cannot stop python task

[XiaoXiaoJiangYun]

Problem (one or two sentences)

1. create a py script.
2. AI run it, then you can't stop it by click the X button.

Context (who is affected and when)

run python script.

Reproduction steps

1. create a py script.
2. AI run it, then you can't stop it by click the X button.

Expected result

stop the task

Actual result

it runs always

Variations tried (optional)

No response

App Version

v3.50.0

API Provider (optional)

None

Model Used (optional)

No response

Roo Code Task Links (optional)

No response

Relevant logs or errors (optional)

[roomote-v0]

I've analyzed this issue and here's my proposed implementation plan:

Root Cause:

When a user clicks the X button to cancel a task, ClineProvider.cancelTask() calls task.abortTask(), which sets the abort flag and calls dispose(). However, dispose() only releases the terminal association via TerminalRegistry.releaseTerminalsForTask() (which just unlinks the terminal from the task ID) -- it never actually aborts/kills the running terminal process.

The terminalProcess.abort() method exists and works correctly (sends SIGINT for VSCode terminals, SIGKILL for Execa processes), but it is only called via handleTerminalOperation("abort") when the user clicks a terminal-specific cancel button in the chat UI. It is never invoked during the main task cancellation flow triggered by the X button.

Proposed Fix:

Add a call to this.terminalProcess?.abort() in the dispose() method of Task.ts, right before calling TerminalRegistry.releaseTerminalsForTask(). This ensures that when a task is cancelled via the X button, any actively running terminal process (like a Python script) is properly terminated.

The change would be in src/core/task/Task.ts, in the dispose() method (around line 2288):

// Abort any running terminal process before releasing terminals.
try {
    this.terminalProcess?.abort()
} catch (error) {
    console.error("Error aborting terminal process:", error)
}

// Release any terminals associated with this task.
try {
    TerminalRegistry.releaseTerminalsForTask(this.taskId)
} catch (error) {
    console.error("Error releasing terminals:", error)
}

This is a minimal, targeted fix that leverages the existing abort() implementations in both TerminalProcess (sends Ctrl+C/SIGINT) and ExecaTerminalProcess (sends SIGKILL and kills child process tree).

Please mention @roomote in a comment saying that you approve this plan, and I'll proceed with the implementation.

[mini2s]

Problem (one or two sentences)

1. create a py script. 2. AI run it, then you can't stop it by click the X button.

Context (who is affected and when)

run python script.

Reproduction steps

1. create a py script. 2. AI run it, then you can't stop it by click the X button.

Expected result

stop the task

Actual result

it runs always

Variations tried (optional)

No response

App Version

v3.50.0

API Provider (optional)

None

Model Used (optional)

No response

Roo Code Task Links (optional)

No response

Relevant logs or errors (optional)

you can try https://github.com/zgsm-ai/costrict