Techtree Dependency Issues

[Retera]

I found a tower defense map that mostly works https://www.hiveworkshop.com/threads/simple-tower-defense-v3.80868/ (though it eventually crashes)

This could be a basis for replacement assets, since it’s basically just towers and running monsters. No fighting animations etc. Very homogeneous map. Doesn't need many icons

edit: I compared it. Timer and wave counter are missing. Earth quake tower doesn’t seem to do anything. (maybe just visual) Earth quake trap can't be build. Upgrades as dependencies doesn’t work correctly. Level 2 doesn’t satisfy requirement level 1, even though it should.

Originally posted by @basxto in #61

I believe there was a regression in the last year where dependencies were sometimes working and then broke even for simple things -- for example basic structures requiring other structures in a melee gameplay session no longer worked. This seemed to be the result of one of the merged pull requests probably from other users that I may not have read carefully enough, but I believe it was resolved in a branch on one of my local machines. If we can get that branch merged and ensure the issue is resolved, we could close this issue.

I definitely saw a problem pertaining to buildings requiring other buildings, but it should also be the case that buildings requiring "Upgrade/Research" items (such as Iron Forged Swords) would work as well.

[Glasislundr]

This was probably related to my work on transformation abilities, as that affected the setTypeId method in CUnit which is used when upgrading too.

Right now (in my branch),I think the most basic version of requirement unlocks for upgrades are working at the moment. From a quick test, upgrading a Farm to a "Farm 2" fulfilled requirements for both the normal Farm and the "Farm 2".

That said, there seems to be some issue on my branch with removing requirements on kill... When I kill the "Farm 2", the upgrades that required it (and the ones requiring the Farm) still were available rather than becoming unavailable again.

[Glasislundr]

Also noted when testing this that the upgrade progress bar seemed to be using the base unit ID's build time for the bar length (but the actual time taken properly used the build time of the target unit ID). So during testing, my buildings would finish upgrading long before the bar filled.