From 9f8f3a1616335c7b444901e56e7dba9f74994293 Mon Sep 17 00:00:00 2001 From: SuperCake Date: Mon, 28 Sep 2026 05:05:21 +0200 Subject: [PATCH 1/5] fix!: change type from int to bool for boolean member of CAttachmentData --- src/game/client/c_baseanimating.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/game/client/c_baseanimating.h b/src/game/client/c_baseanimating.h index d82ae85f9..043945d48 100644 --- a/src/game/client/c_baseanimating.h +++ b/src/game/client/c_baseanimating.h @@ -81,7 +81,7 @@ class CAttachmentData QAngle m_angRotation; Vector m_vOriginVelocity; int m_nLastFramecount : 31; - int m_bAnglesComputed : 1; + bool m_bAnglesComputed : true; }; From 65331cb2df5ee48bbbb612004c859d054a0e61da Mon Sep 17 00:00:00 2001 From: SuperCake Date: Tue, 29 Sep 2026 01:38:18 +0200 Subject: [PATCH 2/5] fix!: remove unused bool success now the function should be able to return true --- src/game/server/nav_generate.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/game/server/nav_generate.cpp b/src/game/server/nav_generate.cpp index d55cc001d..42363c11e 100644 --- a/src/game/server/nav_generate.cpp +++ b/src/game/server/nav_generate.cpp @@ -1596,7 +1596,6 @@ static bool testStitchConnection( CNavArea *source, CNavArea *target, const Vect else { // test going up ClimbUpHeight - bool success = false; for ( float height = StepHeight; height <= ClimbUpHeight; height += 1.0f ) { trace_t tr; From 0460ec3d3872d1b1aa4b120eb060372089bb02c9 Mon Sep 17 00:00:00 2001 From: SuperCake Date: Tue, 29 Sep 2026 16:57:03 +0200 Subject: [PATCH 3/5] fix!: set calculated coverGoal for navigator --- src/game/server/ai_basenpc_schedule.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/game/server/ai_basenpc_schedule.cpp b/src/game/server/ai_basenpc_schedule.cpp index cbf58df26..78d27b82e 100644 --- a/src/game/server/ai_basenpc_schedule.cpp +++ b/src/game/server/ai_basenpc_schedule.cpp @@ -2167,8 +2167,7 @@ void CAI_BaseNPC::StartTask( const Task_t *pTask ) AIN_DEF_FLAGS, m_hStoredPathTarget ); - // TODO: is this a bug? why goal and not coverGoal? - foundPath = GetNavigator()->SetGoal( goal ); + foundPath = GetNavigator()->SetGoal( coverGoal ); m_flMoveWaitFinished = gpGlobals->curtime + pTask->flTaskData; } From 57edae518040780eac5e87f52aa8bf7d63891ca6 Mon Sep 17 00:00:00 2001 From: SuperCake Date: Mon, 28 Sep 2026 14:22:56 +0200 Subject: [PATCH 4/5] fix!: change member value of CCvarSlider instead of local redefinition In the block directly above member field is changed, so I guess this variable shouldn't be local either. --- src/game/client/swarm/gameui/cvarslider.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/game/client/swarm/gameui/cvarslider.cpp b/src/game/client/swarm/gameui/cvarslider.cpp index 60c334700..edaa4cd85 100644 --- a/src/game/client/swarm/gameui/cvarslider.cpp +++ b/src/game/client/swarm/gameui/cvarslider.cpp @@ -262,7 +262,7 @@ void CCvarSlider::Reset() m_iLastSliderValue = m_iStartValue; return; } - float m_fStartValue = var.GetFloat(); + m_fStartValue = var.GetFloat(); m_fCurrentValue = m_fStartValue; int value = (int)( CVARSLIDER_SCALE_FACTOR * m_fStartValue ); From 08c5b0b22207b27eb45b3da53cc859c5a297e1e8 Mon Sep 17 00:00:00 2001 From: SuperCake Date: Mon, 28 Sep 2026 13:32:48 +0200 Subject: [PATCH 5/5] hide warning C4456: declaration of 'VProf_' hides previous local declaration --- src/game/client/viewrender.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/game/client/viewrender.cpp b/src/game/client/viewrender.cpp index 3f62ae5df..91ea3203f 100644 --- a/src/game/client/viewrender.cpp +++ b/src/game/client/viewrender.cpp @@ -5131,7 +5131,10 @@ bool DrawingShadowDepthView( void ) //for easy externing { return (CurrentViewID() == VIEW_SHADOW_DEPTH_TEXTURE); } - + +#ifdef _WIN32 +#pragma warning (disable:4456) // hide 'declaration of 'VProf_' hides previous local declaration' +#endif //----------------------------------------------------------------------------- // //----------------------------------------------------------------------------- @@ -5220,6 +5223,9 @@ void CShadowDepthView::Draw() #endif } +#ifdef _WIN32 +#pragma warning (default:4456) +#endif //----------------------------------------------------------------------------- //