Skip to content

Function parameter not used, but logging/Exception says otherwise #131

Description

@DominicCronin

https://github.com/sdl/dxa-web-application-java/blob/05cb742c88d819310ee029702f440ee2ecf45c4d/dxa-framework/dxa-common-api/src/main/java/com/sdl/webapp/common/controller/BaseController.java#L67

In getEntityFromRequest, the entityId parameter only gets used in what is then presumably a misleading log message and Exception

The same pattern is also to be seen in getRegionFromRequest

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions