From 842bbdf543a33039506caabd16d1b7fb6d371e15 Mon Sep 17 00:00:00 2001 From: Roman Inflianskas Date: Tue, 13 Oct 2026 11:17:45 +0000 Subject: [PATCH] docs(dash): narrow the test-clock warning's entry points Only an interactive `rocm chat` enters `run_async`; `--prompt`, piped input and redirected stdout render text and return first. On Windows the embedded daemon arm never calls `runner_options`, so no entry point reaches the warning there. And the terminal-handoff rationale belongs to the paths that reach the warning, not the excluded list it previously followed. Signed-off-by: Roman Inflianskas --- apps/rocm/src/dash.rs | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/apps/rocm/src/dash.rs b/apps/rocm/src/dash.rs index e758e3f95..4dd80b3f0 100644 --- a/apps/rocm/src/dash.rs +++ b/apps/rocm/src/dash.rs @@ -128,11 +128,15 @@ const fn gpu_reachable_for_preflight(is_wsl_host: bool, has_usable_gpu: bool) -> /// logical clock rather than restoring wall time. The warning goes to `tracing`, not /// stdout/stderr. It is reached through [`runner_options`], which runtime code /// calls only from [`maybe_spawn_embedded_daemon`]; `run_async` calls that only -/// when [`should_spawn_daemon`] holds, i.e. for a live `rocm dash` and for -/// `rocm chat` (including the launcher's routes into them), not for a focused -/// overlay or `rocm dash --replay`/`--demo`. On those paths the process is about -/// to hand the terminal to the TUI, and the client log is file-only (see -/// `logging.rs`), so a stray stdout/stderr write would corrupt the display. +/// when [`should_spawn_daemon`] holds, i.e. for a live `rocm dash` and for an +/// interactive `rocm chat` (including the launcher's routes into them; a +/// non-interactive `rocm chat` renders text and never enters `run_async`), not +/// for a focused overlay or `rocm dash --replay`/`--demo`. All of this is +/// unix-only: on Windows `maybe_spawn_embedded_daemon` never calls +/// `runner_options`, so no entry point reaches the warning. On the paths that +/// do reach it, the process is about to hand the terminal to the TUI, and the +/// client log is file-only (see `logging.rs`), so a stray stdout/stderr write +/// would corrupt the display. fn dash_test_clock_offset_path(paths: &AppPaths) -> Option { let path = paths.dash_test_clock_file(); if !path.is_file() {