From 7e8858d8efa124d88f20dc23d50a3339188a234c Mon Sep 17 00:00:00 2001 From: Roman Inflianskas Date: Fri, 9 Oct 2026 14:47:56 +0000 Subject: [PATCH] test(examine): include a gfx125x target in the driver property examples The family property draws its targets from GFX_TARGETS, which had no gfx125x entry, so the gfx125* arm of normalize_therock_family was only covered by its single example test. Add gfx1250, the gfx125x target the detection code already produces from a 12.5.0 GC version, so the property now also checks that a host reporting it lands on a known TheRock family in any spelling, and that the family is stable under a second normalization. With the gfx125* arm deleted, the property now fails with minimal input "gfx1250"; without this entry the same mutation passes it. Follows up the review on #558. Signed-off-by: Roman Inflianskas --- crates/rocm-core/src/examine_driver_proptests.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crates/rocm-core/src/examine_driver_proptests.rs b/crates/rocm-core/src/examine_driver_proptests.rs index e5e72f77f..75d31c385 100644 --- a/crates/rocm-core/src/examine_driver_proptests.rs +++ b/crates/rocm-core/src/examine_driver_proptests.rs @@ -31,11 +31,13 @@ fn cases(default: u32) -> u32 { } /// gfx targets a real host reports, as `examine` and the install probes see -/// them. +/// them. At least one per raw-target arm of `normalize_therock_family`, so the +/// family property reaches every arm. const GFX_TARGETS: &[&str] = &[ "gfx900", "gfx906", "gfx908", "gfx90a", "gfx90c", "gfx942", "gfx950", "gfx1010", "gfx1030", "gfx1031", "gfx1032", "gfx1033", "gfx1034", "gfx1035", "gfx1036", "gfx1100", "gfx1101", "gfx1102", "gfx1103", "gfx1150", "gfx1151", "gfx1152", "gfx1153", "gfx1200", "gfx1201", + "gfx1250", ]; fn ubuntu_release() -> impl Strategy {