chore: remove unneeded code

Author: Lash-L

roborock/devices/local_channel.py

@@ -57,15 +57,13 @@ def __init__(self, host: str, local_key: str):
         self._protocol: _LocalProtocol | None = None
         self._subscribers: CallbackList[RoborockMessage] = CallbackList(_LOGGER)
         self._is_connected = False
-        self._local_key = local_key
         self._local_protocol_version: LocalProtocolVersion | None = None
-        self._connect_nonce = get_next_int(10000, 32767)
-        self._params: LocalChannelParams | None = None
-        self._update_encoder_decoder()
+        self._params = LocalChannelParams(local_key=local_key, connect_nonce=get_next_int(10000, 32767), ack_nonce=None)
+        self._update_encoder_decoder(self._params)
 
-    def _update_encoder_decoder(self, params: LocalChannelParams | None = None):
+    def _update_encoder_decoder(self, params: LocalChannelParams):
         if params is None:
-            params = LocalChannelParams(local_key=self._local_key, connect_nonce=self._connect_nonce, ack_nonce=None)
+            params = self._params
         self._params = params
         self._encoder = create_local_encoder(
             local_key=params.local_key, connect_nonce=params.connect_nonce, ack_nonce=params.ack_nonce
@@ -86,7 +84,7 @@ async def _do_hello(self, local_protocol_version: LocalProtocolVersion) -> Local
         request = RoborockMessage(
             protocol=RoborockMessageProtocol.HELLO_REQUEST,
             version=local_protocol_version.encode(),
-            random=self._connect_nonce,
+            random=self._params.connect_nonce,
             seq=1,
         )
         try:
@@ -101,7 +99,7 @@ async def _do_hello(self, local_protocol_version: LocalProtocolVersion) -> Local
                 local_protocol_version,
             )
             return LocalChannelParams(
-                local_key=self._local_key, connect_nonce=self._connect_nonce, ack_nonce=response.random
+                local_key=self._params.local_key, connect_nonce=self._params.connect_nonce, ack_nonce=response.random
             )
         except RoborockException as e:
             _LOGGER.debug(
@@ -114,7 +112,7 @@ async def _do_hello(self, local_protocol_version: LocalProtocolVersion) -> Local
 
     async def _hello(self):
         """Send hello to the device to negotiate protocol."""
-        attempt_versions = [LocalProtocolVersion.L01, LocalProtocolVersion.L01]
+        attempt_versions = [LocalProtocolVersion.V1, LocalProtocolVersion.L01]
         if self._local_protocol_version:
             # Sort to try the preferred version first
             attempt_versions.sort(key=lambda v: v != self._local_protocol_version)

tests/devices/test_local_channel.py

@@ -63,7 +63,9 @@ async def setup_local_channel_with_hello_mock() -> LocalChannel:
 
     async def mock_do_hello(_: LocalProtocolVersion):
         """Mock _do_hello to return successful params without sending actual request."""
-        return LocalChannelParams(local_key=channel._local_key, connect_nonce=channel._connect_nonce, ack_nonce=54321)
+        return LocalChannelParams(
+            local_key=channel._params.local_key, connect_nonce=channel._params.connect_nonce, ack_nonce=54321
+        )
 
     # Replace the _do_hello method
     setattr(channel, "_do_hello", mock_do_hello)
@@ -257,7 +259,7 @@ async def mock_do_hello(local_protocol_version: LocalProtocolVersion) -> LocalCh
         elif local_protocol_version == LocalProtocolVersion.L01:
             # Second attempt (L01) succeeds
             return LocalChannelParams(
-                local_key=channel._local_key, connect_nonce=channel._connect_nonce, ack_nonce=54321
+                local_key=channel._params.local_key, connect_nonce=channel._params.connect_nonce, ack_nonce=54321
             )
         return None
 
@@ -285,12 +287,12 @@ async def mock_do_hello(local_protocol_version: LocalProtocolVersion) -> LocalCh
         if local_protocol_version == LocalProtocolVersion.V1:
             # V1 succeeds on first attempt
             return LocalChannelParams(
-                local_key=channel._local_key, connect_nonce=channel._connect_nonce, ack_nonce=67890
+                local_key=channel._params.local_key, connect_nonce=channel._params.connect_nonce, ack_nonce=67890
             )
         elif local_protocol_version == LocalProtocolVersion.L01:
             # L01 would succeed but we shouldn't reach it
             return LocalChannelParams(
-                local_key=channel._local_key, connect_nonce=channel._connect_nonce, ack_nonce=99999
+                local_key=channel._params.local_key, connect_nonce=channel._params.connect_nonce, ack_nonce=99999
             )
         return None
 
@@ -346,7 +348,7 @@ async def mock_do_hello(local_protocol_version: LocalProtocolVersion) -> LocalCh
         if local_protocol_version == LocalProtocolVersion.L01:
             # L01 succeeds
             return LocalChannelParams(
-                local_key=channel._local_key, connect_nonce=channel._connect_nonce, ack_nonce=11111
+                local_key=channel._params.local_key, connect_nonce=channel._params.connect_nonce, ack_nonce=11111
             )
         return None