From 8712afbfd9093cb10d94de4c61f99b322e85491e Mon Sep 17 00:00:00 2001
From: Brad Barnett <127794626+bdbarnett@users.noreply.github.com>
Date: Tue, 27 Oct 2026 17:30:00 -0500
Subject: [PATCH] Controls page: units for Compressor, Overdrive, Exciter and
 Distortion

---
 docs/reference/effect-controls.md | 24 ++++++++++++------------
 lib/audioeffects/compressor.py    |  2 ++
 lib/audioeffects/distortion.py    |  1 +
 lib/audioeffects/exciter.py       |  1 +
 lib/audioeffects/overdrive.py     |  1 +
 5 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/docs/reference/effect-controls.md b/docs/reference/effect-controls.md
index 72bffb95..ec802bd1 100644
--- a/docs/reference/effect-controls.md
+++ b/docs/reference/effect-controls.md
@@ -140,18 +140,18 @@ Patches: Metallic; Ringing Pitch; Soft Ripple; Dark Resonator; Single Slap; Filt
 | Knob | Spans |
 |---|---|
 | Character | 0 to 3 |
-| Threshold | -60 to 0 |
+| Threshold | -60 dB to 0 dB |
 | Ratio | 1 to 1000, log |
-| Attack | 300 to 0.02, log |
-| Release | 5000 to 20, log |
-| Release Slow | 25000 to 100, log |
+| Attack | 300 ms to 0.02 ms, log |
+| Release | 5000 ms to 20 ms, log |
+| Release Slow | 25000 ms to 100 ms, log |
 | Memory | 0 to 1 |
-| Knee | 0 to 36 |
+| Knee | 0 dB to +36 dB |
 | Detector | off or on |
-| RMS Window | 1 to 100, log |
+| RMS Window | 1 ms to 100 ms, log |
 | Emphasis | 0 to 1 |
-| Emphasis Freq | 30 to 2000, log |
-| Makeup | -12 to 24 |
+| Emphasis Freq | 30 Hz to 2 kHz, log |
+| Makeup | -12 dB to +24 dB |
 | Mix | 0 to 1 |
 
 Patches: Level Ride; Fast Peak Catch; Everything At Once; Bus Glue; Voice Ride; Let The Stick Through; Parallel Squash; Wide Knee Glue; Vari-Mu TC1; Vari-Mu TC2; Vari-Mu TC3; Vari-Mu TC4; Vari-Mu TC5; Vari-Mu TC6; Compressor - lean.
@@ -217,7 +217,7 @@ Patches: Clean Repeats; Eighth Notes; Dotted Eighths; Short Doubling; Long Ambie
 | Mix | 0 to 1 |
 | Character | off or on |
 | Ceiling | 0.5 to 2 |
-| Boost | 0 to 35 |
+| Boost | 0 dB to +35 dB |
 | Asymmetry | 0 to 1 |
 | Body | 0 to 1 |
 
@@ -246,11 +246,11 @@ Patches: Wide Band; Boxiness Control; Harshness Control; Low End Tamer; Sibilanc
 
 | Knob | Spans |
 |---|---|
-| Tune | 600 to 6000, log |
+| Tune | 600 Hz to 6 kHz, log |
 | Harmonics | 0 to 1 |
 | Mix | 0 to 0.7 |
 | Character | off or on |
-| Output | -24 to 0 |
+| Output | -24 dB to 0 dB |
 
 Patches: Voice Air; Percussive Edge; Mix Sheen; Mid Presence; Transient Bite; Transient Soft; Wet Sidechain.
 
@@ -504,7 +504,7 @@ Patches: Octave down under the dry; Both octaves; Octaves alone, no dry; Bass gu
 | Tone | 0 to 1 |
 | Level | 0 to 1 |
 | Mix | 0 to 1 |
-| Body | 360 to 1440, log |
+| Body | 360 Hz to 1.44 kHz, log |
 | Ceiling | 0.5 to 1 |
 | Symmetry | -1 to 1 |
 
diff --git a/lib/audioeffects/compressor.py b/lib/audioeffects/compressor.py
index ab751bc9..1658d5e5 100644
--- a/lib/audioeffects/compressor.py
+++ b/lib/audioeffects/compressor.py
@@ -233,6 +233,8 @@ class Compressor(_component.Component):
         (-12.0, 24.0),                  # 12 Makeup, dB
         (0.0, 1.0),                     # 13 Mix
     )
+    _MACRO_UNITS = {1: "dB", 3: "ms", 4: "ms", 5: "ms", 7: "dB", 9: "ms", 11: "Hz",
+                    12: "dB"}
 
     #: Patches 8-13 are the Fairchild's six TIME CONSTANT positions, in the
     #: manual's order, and are the only patches traits M2 and M3 are read on.
diff --git a/lib/audioeffects/distortion.py b/lib/audioeffects/distortion.py
index d178034a..026a54bf 100644
--- a/lib/audioeffects/distortion.py
+++ b/lib/audioeffects/distortion.py
@@ -545,6 +545,7 @@ class Distortion(_component.Component):
         (0.0, 1.0),
         (0.0, 1.0),
     )
+    _MACRO_UNITS = {7: "dB"}
     PATCHES = {
         0: ("Filter Half Mid Gain", (64, 64, 64, 100, 127, 0, 42, 0, 0, 0)),
         1: ("Filter Open Low Gain", (24, 0, 64, 110, 127, 0, 42, 0, 0, 0)),
diff --git a/lib/audioeffects/exciter.py b/lib/audioeffects/exciter.py
index 8df7fec1..036719b1 100644
--- a/lib/audioeffects/exciter.py
+++ b/lib/audioeffects/exciter.py
@@ -515,6 +515,7 @@ class Exciter(_component.Component):
         (0.0, 1.0),
         (-24.0, 0.0),
     )
+    _MACRO_UNITS = {0: "Hz", 4: "dB"}
     PATCHES = {
         0: ("Voice Air", (105, 32, 54, 0, 127)),
         1: ("Percussive Edge", (89, 102, 82, 127, 127)),
diff --git a/lib/audioeffects/overdrive.py b/lib/audioeffects/overdrive.py
index 218b8539..52710d98 100644
--- a/lib/audioeffects/overdrive.py
+++ b/lib/audioeffects/overdrive.py
@@ -532,6 +532,7 @@ class Overdrive(_component.Component):
         (0.5, 1.0),
         (-1.0, 1.0),
     )
+    _MACRO_UNITS = {4: "Hz"}
     PATCHES = {
         0: ("Mid Drive Flat", (64, 64, 100, 127, 64, 127, 64)),
         1: ("Low Drive Bright", (16, 110, 100, 127, 64, 127, 64)),