"+% to Critical Damage Bonus" (local) being applied as global in PoB

[ttei080]

Check version

• I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

• I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

• I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the behaviour in-game?

The local critical damage affix behaves similarly to local weapon crit rate in that it's additive with the base pool, and is then scaled by all global increased critical damage bonus %.
Attacks that have their own base damage (e.g. Bloodhound's Mark explosion) do not use the weapon, neither do shield skills, so local weapon crit is not applied.

What is the behaviour in Path of Building?

in pob the local crit bonus is being applied globally, regardless of the skill using the weapon or not.
The numerical values are calculated correctly, but it is being applied incorrectly.
It should only be applying locally for attacks using that weapon.

How to reproduce the issue

1. load pob
2. select a shield skill or bloodhound's mark
3. equip nebuloch or a mace with local critical damage bonus

PoB for PoE2 build code

https://pobb.in/ruK1_DSfh6bZ

Screenshots

https://imgur.com/a/6slxHQL