Hi, @AndyMc629, thanks for the book.
I am not sure if it's intentional, but I wanted to raise a small, yet important point in the ingest_and_prep_data function of classify_example.py, Chapter01/classification. I believe X_test should also be transformed identically to X_train.
I understand this example is meant to be illustrative, and training works fine. But evaluating the model on X_test will fail with ValueError: could not convert string to float: 'entrepreneur', because the test set never undergoes one-hot encoding.
I think, readers must be provided a more clearer example than this.
Hi, @AndyMc629, thanks for the book.
I am not sure if it's intentional, but I wanted to raise a small, yet important point in the
ingest_and_prep_datafunction of classify_example.py, Chapter01/classification. I believeX_testshould also betransformed identically toX_train.I understand this example is meant to be illustrative, and training works fine. But evaluating the model on
X_testwill fail withValueError: could not convert string to float: 'entrepreneur', because the test set never undergoes one-hot encoding.I think, readers must be provided a more clearer example than this.