Skip to content

Commit c038359

Browse files
mgaffiganmgaffigan
committed
Use Integer.valueOf for caching benefit
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
1 parent a7eac1f commit c038359

10 files changed

Lines changed: 28 additions & 28 deletions

File tree

‎client/src/com/mirth/connect/client/ui/browsers/event/EventBrowser.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ public void done() {
476476
updateEventTable(events);
477477

478478
if (!events.hasNextPage()) {
479-
events.setItemCount((long)(((retrievedPageNumber - 1) * events.getPageSize()) + events.size()));
479+
events.setItemCount(Long.valueOf(((retrievedPageNumber - 1) * events.getPageSize()) + events.size()));
480480
enableCountButton = false;
481481
}
482482
} else {
@@ -485,7 +485,7 @@ public void done() {
485485
model.refreshDataVector(new Object[0][0]);
486486
}
487487

488-
events.setItemCount((long)((retrievedPageNumber - 1) * events.getPageSize()));
488+
events.setItemCount(Long.valueOf((retrievedPageNumber - 1) * events.getPageSize()));
489489
enableCountButton = false;
490490
pageNumberField.setText("0");
491491
}

‎client/src/com/mirth/connect/client/ui/browsers/message/MessageBrowser.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -968,11 +968,11 @@ public void done() {
968968
}
969969

970970
if (!messages.hasNextPage()) {
971-
messages.setItemCount((long)(((retrievedPageNumber - 1) * messages.getPageSize()) + messages.size()));
971+
messages.setItemCount(Long.valueOf(((retrievedPageNumber - 1) * messages.getPageSize()) + messages.size()));
972972
enableCountButton = false;
973973
}
974974
} else {
975-
messages.setItemCount((long)((retrievedPageNumber - 1) * messages.getPageSize()));
975+
messages.setItemCount(Long.valueOf((retrievedPageNumber - 1) * messages.getPageSize()));
976976
enableCountButton = false;
977977
pageNumberField.setText("0");
978978
}

‎donkey/src/main/java/com/mirth/connect/donkey/server/data/buffered/BufferedDao.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public void commit() {
7777

7878
@Override
7979
public void commit(boolean durable) {
80-
commit((Boolean) durable);
80+
commit(Boolean.valueOf(durable));
8181
}
8282

8383
private void commit(Boolean durable) {

‎donkey/src/test/java/com/mirth/connect/donkey/test/DestinationConnectorTests.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ private void testProcess(boolean queueNull, boolean queueEnabled, boolean queueS
328328

329329
if (retryCount > 0) {
330330
// assert that the connector attempted to send the message the correct number of times
331-
assertEquals((Integer)(dispatcherConnectorProperties.getRetryCount() + 1), TestUtils.getSendAttempts(channel.getChannelId(), dispatchResult.getMessageId()));
331+
assertEquals(Integer.valueOf(dispatcherConnectorProperties.getRetryCount() + 1), TestUtils.getSendAttempts(channel.getChannelId(), dispatchResult.getMessageId()));
332332
} else {
333333
if (queueNull || !queueEnabled || queueSendFirst) {
334334
// Assert that the sent content was stored

‎donkey/src/test/java/com/mirth/connect/donkey/test/DonkeyDaoTests.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1444,7 +1444,7 @@ public final void testGetMaxMessageId() throws Exception {
14441444

14451445
try {
14461446
dao = daoFactory.getDao();
1447-
assertEquals(maxId, (Long)dao.getMaxMessageId(channel.getChannelId()));
1447+
assertEquals(maxId, Long.valueOf(dao.getMaxMessageId(channel.getChannelId())));
14481448
} finally {
14491449
TestUtils.close(dao);
14501450
}
@@ -1468,7 +1468,7 @@ public final void testGetMaxMessageId() throws Exception {
14681468

14691469
try {
14701470
dao = daoFactory.getDao();
1471-
assertEquals(maxId, (Long)dao.getMaxMessageId(channel.getChannelId()));
1471+
assertEquals(maxId, Long.valueOf(dao.getMaxMessageId(channel.getChannelId())));
14721472
} finally {
14731473
TestUtils.close(dao);
14741474
}

‎server/src/com/mirth/connect/server/controllers/DonkeyEngineController.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -966,11 +966,11 @@ public int compare(DashboardStatus o1, DashboardStatus o2) {
966966
}
967967

968968
protected Long getSourceQueueSize(Channel channel) {
969-
return (long)(channel.getSourceQueue().size());
969+
return Long.valueOf(channel.getSourceQueue().size());
970970
}
971971

972972
protected Long getDestinationQueueSize(DestinationConnector destinationConnector) {
973-
return (long)(destinationConnector.getQueue().size());
973+
return Long.valueOf(destinationConnector.getQueue().size());
974974
}
975975

976976
@Override

‎server/src/org/mozilla/javascript/NativeBoolean.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public Object execIdCall(IdFunctionObject f, Context cx, Scriptable scope,
101101
return value ? "true" : "false";
102102

103103
case Id_toSource:
104-
return value ? "new Boolean(true)" : "new Boolean(false)";
104+
return value ? "(new Boolean(true))" : "(new Boolean(false))";
105105

106106
case Id_valueOf:
107107
return ScriptRuntime.wrapBoolean(value);

‎server/src/org/mozilla/javascript/tools/debugger/SwingGui.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -787,7 +787,7 @@ static void setResizeWeight(JSplitPane pane, double weight) {
787787
try {
788788
Method m = JSplitPane.class.getMethod("setResizeWeight",
789789
new Class[]{double.class});
790-
m.invoke(pane, new Object[]{(double)weight});
790+
m.invoke(pane, new Object[]{weight});
791791
} catch (NoSuchMethodException exc) {
792792
} catch (IllegalAccessException exc) {
793793
} catch (java.lang.reflect.InvocationTargetException exc) {

‎server/test/com/mirth/connect/connectors/tcp/TcpDispatcherTest.java‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -303,8 +303,8 @@ public void testMessageSentWhenOneOfMultipleClientsClosed() throws Exception {
303303
}
304304
}
305305

306-
assertEquals((Integer)2, successfulSends);
307-
assertEquals((Integer)2, numberOfClients);
306+
assertEquals(Integer.valueOf(2), successfulSends);
307+
assertEquals(Integer.valueOf(2), numberOfClients);
308308
}
309309

310310
/*
@@ -350,9 +350,9 @@ public void testMLLPMessageSentWhenOneOfMultipleClientsClosed() throws Exception
350350
assertEquals(TEST_MESSAGE_TEMPLATE, socketResult.get("result" + entry.getKey()));
351351
}
352352
}
353-
354-
assertEquals((Integer)2, successfulSends);
355-
assertEquals((Integer)2, numberOfClients);
353+
354+
assertEquals(Integer.valueOf(2), successfulSends);
355+
assertEquals(Integer.valueOf(2), numberOfClients);
356356
}
357357

358358
/*
@@ -389,8 +389,8 @@ public void testMaxConnections() throws Exception {
389389
Integer numberOfClients = (Integer) message.getConnectorMap().get(CONNECTOR_MAP_NO_OF_CLIENTS_KEY);
390390
Integer successfulSends = (Integer) message.getConnectorMap().get(CONNECTOR_MAP_SUCCESSFUL_SENDS_KEY);
391391

392-
assertEquals((Integer)1, successfulSends);
393-
assertEquals((Integer)1, numberOfClients);
392+
assertEquals(Integer.valueOf(1), successfulSends);
393+
assertEquals(Integer.valueOf(1), numberOfClients);
394394
}
395395

396396
/*
@@ -413,8 +413,8 @@ public void testMessageResponseWithNoConnections() throws Exception {
413413
Integer successfulSends = (Integer) message.getConnectorMap().get(CONNECTOR_MAP_SUCCESSFUL_SENDS_KEY);
414414

415415
assertEquals(Status.QUEUED, response.getStatus());
416-
assertEquals((Integer)0, successfulSends);
417-
assertEquals((Integer)0, numberOfClients);
416+
assertEquals(Integer.valueOf(0), successfulSends);
417+
assertEquals(Integer.valueOf(0), numberOfClients);
418418
}
419419

420420
/*
@@ -457,8 +457,8 @@ public void testMessageResponseWhenAllConnectionsClosed() throws Exception {
457457
Integer successfulSends = (Integer) message.getConnectorMap().get(CONNECTOR_MAP_SUCCESSFUL_SENDS_KEY);
458458

459459
assertEquals(Status.QUEUED, response.getStatus());
460-
assertEquals((Integer)0, successfulSends);
461-
assertEquals((Integer)0, numberOfClients);
460+
assertEquals(Integer.valueOf(0), successfulSends);
461+
assertEquals(Integer.valueOf(0), numberOfClients);
462462
}
463463

464464
/*
@@ -501,8 +501,8 @@ public void testMLLPMessageResponseWhenAllConnectionsClosed() throws Exception {
501501
Integer successfulSends = (Integer) message.getConnectorMap().get(CONNECTOR_MAP_SUCCESSFUL_SENDS_KEY);
502502

503503
assertEquals(Status.QUEUED, response.getStatus());
504-
assertEquals((Integer)0, successfulSends);
505-
assertEquals((Integer)0, numberOfClients);
504+
assertEquals(Integer.valueOf(0), successfulSends);
505+
assertEquals(Integer.valueOf(0), numberOfClients);
506506
}
507507

508508
/*
@@ -616,8 +616,8 @@ public void testWhenSendToOneOfMultipleClientsErrors() throws Exception {
616616

617617
log(message.getConnectorMap().get(CONNECTOR_MAP_ALL_RESPONSES_KEY));
618618
assertEquals(Status.SENT, response.getStatus());
619-
assertEquals((Integer)2, successfulSends);
620-
assertEquals((Integer)3, numberOfClients);
619+
assertEquals(Integer.valueOf(2), successfulSends);
620+
assertEquals(Integer.valueOf(3), numberOfClients);
621621
}
622622

623623
@Test

‎server/test/com/mirth/connect/server/api/servlets/ChannelServletTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ private void verifyChannel1(Channel channel, boolean includeCodeTemplateLibrarie
197197
ChannelExportData exportData = channel.getExportData();
198198
assertTrue(exportData.getMetadata().isEnabled());
199199
assertTrue(exportData.getMetadata().getPruningSettings().isArchiveEnabled());
200-
assertEquals((Integer)7, exportData.getMetadata().getPruningSettings().getPruneContentDays());
200+
assertEquals(Integer.valueOf(7), exportData.getMetadata().getPruningSettings().getPruneContentDays());
201201

202202
assertEquals(2, exportData.getChannelTags().size());
203203
assertTrue(exportData.getChannelTags().contains(new ChannelTag("tag1", "Tag 1", new HashSet<>(Arrays.asList(new String[] { CHANNEL_ID_1, CHANNEL_ID_2 })))));

0 commit comments

Comments
 (0)