Some map sizes have out by one errors

[Mortecha]

Describe the bug
While playing some maps, I've noticed that some have out by one errors, in most cases the boundary has been extended by one and allows the player to walk around obstacles they normally would have to go another way. I've highlighted M12P2 and M15P2, but there are others I know of but have to play through again to remember exactly which maps they are.

To Reproduce
Steps to reproduce the behavior:

1. Play the affected map and head near the boundary that's been affected to observe.
2. See error

Expected behavior
The boundary should be a specific size as designed, allowing for a larger boundary creates new paths to walk avoiding hazards and also ruins the map artistically.

Screenshots
M12P2

M15P1

Desktop (please complete the following information):

• OS: Windows 11
• Version: 189FA1C

[segrax]

Is your game data modified? those columns are supposed to be there, but the data is wrong

[Mortecha]

I have not modified the files, unless the extraction process I used has modified them.

I'll try another set of files and see if the error occurs with them.

[segrax]

i know the Amiga floppy retail version and the dos cd version are both ok,

Check the console when you start the game, it does an MD5 check on start and will warn if they dont match,

or if you want to check them manually, (Amiga Floppy Retail)

    { "mapm32.map", "A0FEEA41BCDD44502ACE29B0D3B678D1" },
    { "mapm32.spt", "87E83FBC6B72846666AB61246D42D790" },
    { "mapm33.map", "44AC7495D20AB2F9F71E7AA641DD2763" },
    { "mapm33.spt", "AB9EF2E58F0D052AAEBF09B8D9FC4555" },
    { "mapm34.map", "1BF79B2F821365586FD3A0EF6FAE8746" },
    { "mapm34.spt", "54ADA3E4D5B8519D277D5C0DA1988B0D" },
    { "mapm35.map", "47B9D9400454BA2EC101AFE3D2E6C158" },
    { "mapm35.spt", "C94BDE0F65082BAA0E398CECCBDC17DA" },
    { "mapm36.map", "22617DDB6184D707FC51BC24B4BDFCAB" },
    { "mapm36.spt", "856B5F249B2B907077C326EEAA31C072" },

[Mortecha]

I've just checked and mine are identical, I'll just do a sanity check and reinstall from scratch just in case.

a0feea41bcdd44502ace29b0d3b678d1  C:\Users\samke\Documents\OpenFodder\Data\Amiga\mapm32.map
87e83fbc6b72846666ab61246d42d790  C:\Users\samke\Documents\OpenFodder\Data\Amiga\mapm32.spt
44ac7495d20ab2f9f71e7aa641dd2763  C:\Users\samke\Documents\OpenFodder\Data\Amiga\mapm33.map
ab9ef2e58f0d052aaebf09b8d9fc4555  C:\Users\samke\Documents\OpenFodder\Data\Amiga\mapm33.spt
1bf79b2f821365586fd3a0ef6fae8746  C:\Users\samke\Documents\OpenFodder\Data\Amiga\mapm34.map
54ada3e4d5b8519d277d5c0da1988b0d  C:\Users\samke\Documents\OpenFodder\Data\Amiga\mapm34.spt
47b9d9400454ba2ec101afe3d2e6c158  C:\Users\samke\Documents\OpenFodder\Data\Amiga\mapm35.map
c94bde0f65082baa0e398ceccbdc17da  C:\Users\samke\Documents\OpenFodder\Data\Amiga\mapm35.spt
22617ddb6184d707fc51bc24b4bdfcab  C:\Users\samke\Documents\OpenFodder\Data\Amiga\mapm36.map
856b5f249b2b907077c326eeaa31c072  C:\Users\samke\Documents\OpenFodder\Data\Amiga\mapm36.spt

[segrax]

hmm a rather curious problem,

do you have the dos data?
if so, does it occur with that too?

[segrax]

Have you tried the random map feature?

I'm interested to see if any map tile problems show up there

I assume the problem is in this function, but i have no idea what would be going wrong here for you, and not everyone else... unless there is a hardware problem

openfodder/Source/Amiga/Graphics_Amiga.cpp

Line 734 in 1e8ea53

void cGraphics_Amiga::MapTiles_Draw() {

[segrax]

Unable to replicate and stale, but will continue to investigate if we can get more information

[segrax]

Reopened, this issue is now happening for me

[segrax]

so it seems this is actually the original behavior, on the dos version,

however the Amiga version is different

Dos:

Amiga:

Amiga map screen (those strange parts are clearly visible)

[segrax]

@Mortecha so the issue is actually just a difference between the DOS and Amiga versions, altho its really not clear why it wasnt occurring for me previously, nothing has changed around this particular code

the most noticeable place this difference occurs is on mission 1,
on the Amiga, the camera can't move as the allowed size is exactly the same as the allowed map size.
On dos however, its allowed an extra row of tiles on each side, so the camera can pan all directions