Improve functional test: assert directly on raw response content instead of json_decode

kayjoosten · kayjoosten · commit 53fbc96f76bb · 2026-03-27T11:31:19.000+01:00
diff --git a/tests/functional/OpenConext/EngineBlockBundle/Controller/Api/ConnectionsControllerTest.php b/tests/functional/OpenConext/EngineBlockBundle/Controller/Api/ConnectionsControllerTest.php
@@ -426,8 +426,7 @@ public function pushing_idp_with_discovery_missing_english_name_returns_bad_requ
         $this->assertJson($client->getResponse()->getContent());
         $isContentTypeJson = $client->getResponse()->headers->contains('Content-Type', 'application/json');
         $this->assertTrue($isContentTypeJson, 'Response should have Content-Type: application/json header');
-        $message = json_decode($client->getResponse()->getContent());
-        $this->assertStringContainsString('name_en', $message);
+        $this->assertStringContainsString('name_en', $client->getResponse()->getContent());
     }
 
     public static function invalidHttpMethodProvider()

Original file line number	Diff line number	Diff line change
`@@ -426,8 +426,7 @@ public function pushing_idp_with_discovery_missing_english_name_returns_bad_requ`
`426`	`426`	`$this->assertJson($client->getResponse()->getContent());`
`427`	`427`	`$isContentTypeJson = $client->getResponse()->headers->contains('Content-Type', 'application/json');`
`428`	`428`	`$this->assertTrue($isContentTypeJson, 'Response should have Content-Type: application/json header');`
`429`		`- $message = json_decode($client->getResponse()->getContent());`
`430`		`- $this->assertStringContainsString('name_en', $message);`
	`429`	`+ $this->assertStringContainsString('name_en', $client->getResponse()->getContent());`
`431`	`430`	`}`
`432`	`431`
`433`	`432`	`public static function invalidHttpMethodProvider()`