fix(linux): run the staged executable of release builds

Author: triniwiz

lib/common/mobile/linux/linux-application-manager.ts

@@ -44,18 +44,19 @@ export class LinuxApplicationManager extends ApplicationManagerBase {
 		});
 	}
 
-	/** `packageFilePath` is the executable in the build output. */
+	/** `packageFilePath` is the executable (debug) or the `.tar.gz` (release) in the build output. */
 	public async installApplication(
 		packageFilePath: string,
 		appIdentifier?: string,
 		_buildData?: IBuildData,
 	): Promise<void> {
-		fs.chmodSync(packageFilePath, 0o755);
-		this._executables[path.basename(packageFilePath)] = packageFilePath;
+		const executable = LinuxApplicationManager.executableIn(packageFilePath);
+		fs.chmodSync(executable, 0o755);
+		this._executables[path.basename(executable)] = executable;
 		if (appIdentifier) {
-			this._executables[appIdentifier] = packageFilePath;
+			this._executables[appIdentifier] = executable;
 			try {
-				installDebugDesktopEntry(path.dirname(packageFilePath), appIdentifier);
+				installDebugDesktopEntry(path.dirname(executable), appIdentifier);
 			} catch (e) {
 				this.$logger.warn(
 					`Couldn't register ${appIdentifier} with the desktop: ${e?.message ?? e}`,
@@ -64,6 +65,14 @@ export class LinuxApplicationManager extends ApplicationManagerBase {
 		}
 	}
 
+	/** Release archives are packed from the staged `<name>/<name>`. */
+	private static executableIn(packageFilePath: string): string {
+		const archive = path.basename(packageFilePath).match(/^(.+)\.tar\.gz$/);
+		return archive
+			? path.join(path.dirname(packageFilePath), archive[1], archive[1])
+			: packageFilePath;
+	}
+
 	public async uninstallApplication(appIdentifier: string): Promise<void> {
 		delete this._executables[appIdentifier];
 	}

test/services/linux-application-manager.ts

@@ -89,6 +89,21 @@ describe.runIf(isLinux)("LinuxApplicationManager", () => {
 		await waitFor(() => lines.includes("synced"));
 	});
 
+	it("runs the staged executable of a release archive", async () => {
+		const staged = path.join(dir, "demo");
+		fs.mkdirSync(staged);
+		fs.writeFileSync(path.join(staged, "demo"), "#!/bin/sh\necho release\n");
+		const archive = path.join(dir, "demo.tar.gz");
+		fs.writeFileSync(archive, "not a script");
+		await manager.installApplication(archive, "org.demo");
+		assert.equal(fs.statSync(archive).mode & 0o111, 0);
+		await manager.startApplication(<any>{
+			appId: "org.demo",
+			projectName: "demo",
+		});
+		await waitFor(() => lines.includes("release"));
+	});
+
 	it("fails to start an app that wasn't built", async () => {
 		let error: Error;
 		try {