Merge pull request #37 from NHSDigital/bugifx/fix-error-helper-link-with-icon

fix link with icon button style

Author: suezhou

CHANGELOG.md

@@ -1,5 +1,5 @@
 ## [Unreleased]
-* no unreleased changes
+* fix link with icon button style
 
 ## 2.4.1 / 2025-02-03
 ### Fixed

app/helpers/ndr_error/errors_helper.rb

@@ -57,7 +57,7 @@ def downstream_fingerprint_link(print)
     end
 
     def ticket_link_for(fingerprint, small = false) # rubocop:disable Style/OptionalBooleanParameter
-      text = "#{bootstrap_icon_tag('asterisk', :bi)} View ticket"
+      text = bootstrap_icon_tag('asterisk', :bi) + ' View ticket' # rubocop:disable Style/StringConcatenation
       css  = 'btn btn-outline-secondary'
       css << ' btn-xs' if small
 
@@ -67,14 +67,14 @@ def ticket_link_for(fingerprint, small = false) # rubocop:disable Style/Optional
 
     def edit_button_for(fingerprint)
       css   = 'btn btn-outline-secondary'
-      text  = "#{bootstrap_icon_tag('pencil', :bi)} Edit Ticket"
+      text  = bootstrap_icon_tag('pencil', :bi) + ' Edit Ticket' # rubocop:disable Style/StringConcatenation
 
       link_to(text, edit_error_fingerprint_path(fingerprint), class: css)
     end
 
     def purge_button_for(fingerprint)
       css   = 'btn btn-danger'
-      text  = "#{bootstrap_icon_tag('trash-fill', :bi)} Purge"
+      text  = bootstrap_icon_tag('trash-fill', :bi) + ' Purge' # rubocop:disable Style/StringConcatenation
 
       options = {
         'method'       => :delete,