Skip to content

Commit e41bfd7

Browse files
test: fixed flights data contract detail and added additional check in multi node flights test
1 parent 874c030 commit e41bfd7

2 files changed

Lines changed: 10 additions & 5 deletions

File tree

tests/features/flights.feature

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,9 @@ Feature: Pipeline tests using the flights dataset
4444
When I run the data contract phase
4545
Then there are no file rejections from the data_contract phase
4646
And there is 1 record rejection from the data_contract phase
47-
# And there are errors with the following details and associated error_count from the data_contract phase
48-
# | ErrorType | ErrorCode | error_count |
49-
# | record | CountryIdIsMissing | 1 |
47+
And there are errors with the following details and associated error_count from the data_contract phase
48+
| FailureType | ErrorCode | error_count |
49+
| record | CountryIdIsMissing | 1 |
5050
When I run the business rules phase
5151
Then there are errors with the following details and associated error_count from the business_rules phase
5252
| ErrorType | ErrorCode | error_count |
@@ -167,7 +167,7 @@ Feature: Pipeline tests using the flights dataset
167167
When I run the business rules phase
168168
Then there are errors with the following details and associated error_count from the business_rules phase
169169
| ErrorType | Status | ErrorCode | error_count |
170-
| record | error | StaffIDMissing | 6 |
170+
| record | error | StaffIDMissing | 7 |
171171
| record | error | AirportHasNoStaff | 1 |
172172
| record | error | FlightHasNoAirport | 1 |
173173
| record | error | PassengerHasNoFlight | 1 |
@@ -177,5 +177,5 @@ Feature: Pipeline tests using the flights dataset
177177
| parameter | value |
178178
| record_count | 1 |
179179
| number_submission_rejections | 0 |
180-
| number_record_rejections | 9 |
180+
| number_record_rejections | 10 |
181181
| number_warnings | 0 |

tests/testdata/flights/multi_node_file_rejection.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,11 @@
2929
<staff_name>Alice</staff_name>
3030
<role>Manager</role>
3131
</staff_member>
32+
<staff_member>
33+
<airport_id>1</airport_id>
34+
<staff_name>Alice</staff_name>
35+
<role>Manager</role>
36+
</staff_member>
3237
</staff>
3338
</airport>
3439
<airport>

0 commit comments

Comments
 (0)