From 9ea72f0dc62ddcf235254867319803eedf534922 Mon Sep 17 00:00:00 2001 From: ericpapaluca <59908445+ericpapaluca@users.noreply.github.com> Date: Thu, 3 Oct 2024 15:47:27 +0100 Subject: [PATCH 1/2] Update test_etl.py Remove unrequired f string Signed-off-by: ericpapaluca <59908445+ericpapaluca@users.noreply.github.com> --- test/test_etl.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test_etl.py b/test/test_etl.py index b2ab435..aa30cbf 100644 --- a/test/test_etl.py +++ b/test/test_etl.py @@ -22,7 +22,7 @@ def tearDownClass(cls): def _create_test_database(self): - self.engine = create_engine(f'{test_etl_script.test_db_path}', echo=True) + self.engine = create_engine(test_etl_script.test_db_path, echo=True) def _delete_test_database(self): # Delete the test SQLite database From 0abe1187d4a61320bca92c52f8c692d1b310d174 Mon Sep 17 00:00:00 2001 From: ericpapaluca <59908445+ericpapaluca@users.noreply.github.com> Date: Thu, 3 Oct 2024 15:48:58 +0100 Subject: [PATCH 2/2] Update README.md Improve Background clarity Signed-off-by: ericpapaluca <59908445+ericpapaluca@users.noreply.github.com> --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index d1c138a..087a583 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ The objective of this challenge is to gain insights on problem-solving approache ## Background -A client receives sales data in a text file (CSV format). Each row in this file contains item_id, order_id, product_name, quantity, unit_price. +A client receives sales data in a text file (CSV format). Each row in this file contains a record with columns of the schema item_id, order_id, product_name, quantity, unit_price. The client wants to keep this information in a more accessible storage solution (e.g. a database). Therefore they have created a small python ETL tool to store this data in SQLite. On the back of this, they have created a revenue report with the top 2 products that looks like this: @@ -30,4 +30,4 @@ You are provided with scaffolding code necessary to solve this task: There are many ways of solving the task so don't be afraid of being creative. Feel free to use additional libraries and code as needed. -**Happy coding!** \ No newline at end of file +**Happy coding!**