From 1dd090e45ac73c8f3430a5e70af854f89554d09a Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 27 May 2026 10:50:15 +0200 Subject: [PATCH 1/3] fix: Handle JSONDecodeError in deploy script --- scripts/mediawiki_session.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/scripts/mediawiki_session.py b/scripts/mediawiki_session.py index badba1976a1..98c3750df84 100644 --- a/scripts/mediawiki_session.py +++ b/scripts/mediawiki_session.py @@ -105,10 +105,13 @@ def make_action( print(f"data: {data}") print(f"HTTP Status: {response.status_code}") print(f'Raw response: "{response}"') - parsed_response: dict[str, Any] = response.json() - if "error" in parsed_response.keys(): - raise MediaWikiSessionError(parsed_response["error"]["info"]) - return parsed_response[action] + try: + parsed_response: dict[str, Any] = response.json() + if "error" in parsed_response.keys(): + raise MediaWikiSessionError(parsed_response["error"]["info"]) + return parsed_response[action] + except requests.JSONDecodeError: + raise MediaWikiSessionError(response.text) def cooldown(self): time.sleep(SLEEP_DURATION) From 33865a24276d6f26a727fbbcfc644320d0aeab75 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 27 May 2026 10:54:47 +0200 Subject: [PATCH 2/3] Improve error display --- scripts/mediawiki_session.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mediawiki_session.py b/scripts/mediawiki_session.py index 98c3750df84..97e0005f846 100644 --- a/scripts/mediawiki_session.py +++ b/scripts/mediawiki_session.py @@ -111,7 +111,7 @@ def make_action( raise MediaWikiSessionError(parsed_response["error"]["info"]) return parsed_response[action] except requests.JSONDecodeError: - raise MediaWikiSessionError(response.text) + raise MediaWikiSessionError(f"{response.status_code} ({response.reason}): {response.text}") def cooldown(self): time.sleep(SLEEP_DURATION) From 99d8771f172748fde5ad61cd1d79063d23970bd9 Mon Sep 17 00:00:00 2001 From: SyntacticSalt Date: Wed, 27 May 2026 10:55:56 +0200 Subject: [PATCH 3/3] Make the linter happy --- scripts/mediawiki_session.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scripts/mediawiki_session.py b/scripts/mediawiki_session.py index 97e0005f846..ec081557192 100644 --- a/scripts/mediawiki_session.py +++ b/scripts/mediawiki_session.py @@ -111,7 +111,9 @@ def make_action( raise MediaWikiSessionError(parsed_response["error"]["info"]) return parsed_response[action] except requests.JSONDecodeError: - raise MediaWikiSessionError(f"{response.status_code} ({response.reason}): {response.text}") + raise MediaWikiSessionError( + f"{response.status_code} ({response.reason}): {response.text}" + ) def cooldown(self): time.sleep(SLEEP_DURATION)