Skip to content

Commit e7df5a6

Browse files
Merge 25.11 to 26.1
2 parents 819bd2a + 872e709 commit e7df5a6

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

api/src/org/labkey/api/exp/api/ExpLineage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -384,7 +384,7 @@ else if ((clazz == ExpMaterial.class && target instanceof ExpMaterial) ||
384384
}
385385
else // ExpMaterial or generic Identifiable
386386
{
387-
if (!seen.contains(target))
387+
if (!seen.contains(target) && target != null)
388388
{
389389
stack.add(target);
390390
seen.add(target);

experiment/src/org/labkey/experiment/api/ExpProtocolApplicationImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ private long deleteDataInputs()
411411
OntologyManager.deleteOntologyObjects(svc.getSchema(), new SQLFragment("SELECT " +
412412
dialect.concatenate("'" + DataInput.lsidPrefix() + "'",
413413
"CAST(dataId AS VARCHAR)", "'.'", "CAST(targetApplicationId AS VARCHAR)") +
414-
" FROM " + svc.getTinfoDataInput() + " WHERE TargetApplicationId IN (SELECT RowId FROM exp.ProtocolApplication WHERE RunId = " + getRowId() + ")"), getContainer());
414+
" FROM " + svc.getTinfoDataInput() + " WHERE TargetApplicationId = ?", getRowId()), getContainer());
415415

416416
return Table.delete(ExperimentServiceImpl.get().getTinfoDataInput(), new SimpleFilter(FieldKey.fromParts("TargetApplicationId"), getRowId()));
417417
}
@@ -427,7 +427,7 @@ private long deleteMaterialInputs()
427427
OntologyManager.deleteOntologyObjects(svc.getSchema(), new SQLFragment("SELECT " +
428428
dialect.concatenate("'" + MaterialInput.lsidPrefix() + "'",
429429
"CAST(materialId AS VARCHAR)", "'.'", "CAST(targetApplicationId AS VARCHAR)") +
430-
" FROM " + svc.getTinfoMaterialInput() + " WHERE TargetApplicationId IN (SELECT RowId FROM exp.ProtocolApplication WHERE RunId = " + getRowId() + ")"), getContainer());
430+
" FROM " + svc.getTinfoMaterialInput() + " WHERE TargetApplicationId = ?", getRowId()), getContainer());
431431

432432
return Table.delete(ExperimentServiceImpl.get().getTinfoMaterialInput(), new SimpleFilter(FieldKey.fromParts("TargetApplicationId"), getRowId()));
433433
}

0 commit comments

Comments
 (0)