Skip to content

Document external data table paths in various contexts#584

Open
popescu-v wants to merge 1 commit into
mainfrom
560-specifying-additional-tables-problem-with-reference-table-name
Open

Document external data table paths in various contexts#584
popescu-v wants to merge 1 commit into
mainfrom
560-specifying-additional-tables-problem-with-reference-table-name

Conversation

@popescu-v

Copy link
Copy Markdown
Collaborator
  • In train_predictor, SNB_ or Baseline_-prefixed model dictionaries are generated. Similarly, in train_recoder, R_-prefixed model dictionaries are generated.

  • In deploy_model, these prefixed dictionaries must be used, even for external tables.

  • However, in evaluate_predictor, the original names must be used for external tables, in order to support evaluating several predictors.

Put your message here


TODO Before Asking for a Review

  • Rebase your branch to the latest version of main (or main-v10)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

- In `train_predictor`, `SNB_` or `Baseline_`-prefixed model
  dictionaries are generated. Similarly, in `train_recoder`,
  `R_`-prefixed model dictionaries are generated.

- In `deploy_model`, these prefixed dictionaries must be used, even for
  external tables.

- However, in `evaluate_predictor`, the original names must be used for
  external tables, in order to support evaluating several predictors.
@popescu-v popescu-v requested a review from marcboulle June 8, 2026 14:43
@popescu-v popescu-v self-assigned this Jun 8, 2026
@popescu-v popescu-v linked an issue Jun 8, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specifying additional tables : Problem with reference table name

1 participant