-
Notifications
You must be signed in to change notification settings - Fork 2
Use khiops-core and khiops-driver-* pip packages containing binaries only #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,6 +60,16 @@ jobs: | |
| run: | | ||
| # Install package itself to install the samples datasets | ||
| python -m pip install --upgrade pip | ||
| # Add homogeneous TOML support (Python >= 3.12 has standard tomllib) | ||
| python -m pip install tomli | ||
| # First, install all dependencies except khiops-core and khiops-drivers-* | ||
| python scripts/extract_dependencies_from_pyproject_toml.py -f "pyproject.toml" --exclude-khiops-family > requires-no-khiops.txt | ||
| python -m pip install --user `cat requires-no-khiops.txt` | ||
| # khiops-core and khiops-drivers-* must always be installed from TestPyPI in order to avoid distorting usage statistics | ||
| python scripts/extract_dependencies_from_pyproject_toml.py -f "pyproject.toml" --khiops-family-only > requires-khiops.txt | ||
| python -m pip install --user --index-url https://test.pypi.org/simple `cat requires-khiops.txt` | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not |
||
| rm -f requires-khiops.txt requires-no-khiops.txt | ||
| # Lastly, install khiops-python | ||
| python -m pip install --user . | ||
| kh-download-datasets --force-overwrite --version ${{ inputs.khiops-samples-revision || env.DEFAULT_KHIOPS_SAMPLES_REVISION }} | ||
| kh-status | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -77,6 +77,12 @@ jobs: | |
| run: | | ||
| SAMPLES_REVISION=${{ inputs.samples-revision || env.DEFAULT_SAMPLES_REVISION }} | ||
| echo "SAMPLES_REVISION=$SAMPLES_REVISION" >> "$GITHUB_ENV" | ||
| - name: Checkout sources # Checkout the sources to be able to extract the dependencies list | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| # Get Git tags so that versioneer can function correctly | ||
| # See issue https://github.com/actions/checkout/issues/701 | ||
| fetch-depth: 0 | ||
| - name: Checkout Khiops samples | ||
| uses: actions/checkout@v4 | ||
| with: | ||
|
|
@@ -88,12 +94,13 @@ jobs: | |
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: pip-package | ||
| - name: Install package | ||
| - name: Install the package | ||
| shell: bash | ||
| run: | | ||
| # Allow Pip to write to its cache | ||
| mkdir -p /github/home/.cache/pip | ||
| chown -R $(whoami) /github/home/.cache/pip | ||
|
|
||
| # Install the Khiops Python library | ||
|
|
||
| # A virtual env is mandatory under debian | ||
|
|
@@ -102,6 +109,16 @@ jobs: | |
| source khiops-debian-venv/bin/activate | ||
| fi | ||
| pip install --upgrade pip | ||
| # Add homogeneous TOML support (Python >= 3.12 has standard tomllib) | ||
| pip install tomli | ||
| # First, install all dependencies except khiops-core and khiops-drivers-* | ||
|
popescu-v marked this conversation as resolved.
|
||
| python scripts/extract_dependencies_from_pyproject_toml.py -f "pyproject.toml" --exclude-khiops-family > requires-no-khiops.txt | ||
| pip install `cat requires-no-khiops.txt` | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not |
||
| # khiops-core and khiops-drivers-* must always be installed from TestPyPI in order to avoid distorting usage statistics | ||
| python scripts/extract_dependencies_from_pyproject_toml.py -f "pyproject.toml" --khiops-family-only > requires-khiops.txt | ||
| pip install --index-url https://test.pypi.org/simple `cat requires-khiops.txt` | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not |
||
| rm -f requires-khiops.txt requires-no-khiops.txt | ||
| # Lastly, install khiops-python | ||
| pip install $(ls khiops*.tar.gz) | ||
| if [[ "${{ matrix.container }}" == "debian13" ]]; then | ||
| deactivate | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,11 +19,15 @@ jobs: | |
| - name: Install khiops-python dev dependencies | ||
| run: | | ||
| # Extract and install package dependency requirements from metadata | ||
| pip install pip-tools | ||
| python -m piptools compile -o requirements.txt | ||
|
|
||
| # Install dev dependencies | ||
| pip install -r requirements.txt | ||
| # Add homogeneous TOML support (Python >= 3.12 has standard tomllib) | ||
| pip install tomli | ||
| # First, install all dependencies except khiops-core and khiops-drivers-* | ||
| python scripts/extract_dependencies_from_pyproject_toml.py -f "pyproject.toml" --exclude-khiops-family > requires-no-khiops.txt | ||
| pip install `cat requires-no-khiops.txt` | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not |
||
| # khiops-core and khiops-drivers-* must always be installed from TestPyPI in order to avoid distorting usage statistics | ||
| python scripts/extract_dependencies_from_pyproject_toml.py -f "pyproject.toml" --khiops-family-only > requires-khiops.txt | ||
| pip install --index-url https://test.pypi.org/simple `cat requires-khiops.txt` | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not |
||
| rm -f requires-khiops.txt requires-no-khiops.txt | ||
|
|
||
| # Install black for the samples-generation script | ||
| pip install black | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not
-r requires-no-khiops.txtrather thancat requires-no-khiops.txt?