Fix install on Windows, modernize CI, add Claude integration#2
Open
mrustl wants to merge 1 commit into
Open
Conversation
Resolves "input string 416 is invalid" error from
remotes::install_github("kwb-r/qsimVis@dev") on Windows by replacing
non-ASCII (umlaut) filenames in inst/extdata/verknet/ with ASCII
equivalents (Oe/Ue/Ae/oe/ue). qsimVis_ID columns in impetus
mapping tables updated to match new filenames; model_IDs left
unchanged to preserve compatibility with external simulation output.
Workflows aligned to KWB-R/kwb.pkgbuild style: actions/checkout@v5,
r-lib/actions/setup-r-dependencies@v2, codecov-action@v5,
JamesIves/github-pages-deploy-action@v4.7.3.
Adds claude.yaml and claude-code-review.yaml from kwb.pkgbuild
(requires CLAUDE_CODE_OAUTH_TOKEN secret to be set in repo settings).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remotes::install_github("kwb-r/qsimVis@dev")failed on Windows withinput string 416 is invalidbecause of 9 verknet CSVs with German umlauts. Renamed to ASCII equivalents (Oe / Ue / Ae).qsimVis_IDcolumns inimpetus/mapping tables updated to match new filenames;model_IDsleft unchanged to preserve compat with external QSim output.actions/checkout@v5,r-lib/actions/setup-r-dependencies@v2+check-r-package@v2,codecov-action@v5,JamesIves/github-pages-deploy-action@v4.7.3.claude.yaml(responds to@claudementions in issues/PRs) andclaude-code-review.yaml(auto-reviews PRs), both from kwb.pkgbuild.Action required
Set the
CLAUDE_CODE_OAUTH_TOKENrepository secret in GitHub Actions settings — without it the two Claude workflows will fail at runtime.Test plan
remotes::install_github("kwb-r/qsimVis@dev")succeeds on WindowsCLAUDE_CODE_OAUTH_TOKENsecret and verify@claudemention triggers the workflowGenerated with Claude Code