From 9ac88d148cb6c985e8bb545908b855feaf64a117 Mon Sep 17 00:00:00 2001 From: dehann Date: Wed, 10 Jun 2026 10:14:40 -0700 Subject: [PATCH 1/2] compat, avoid show bw bug, comment --- Project.toml | 2 +- src/entities/HomotopyDensity.jl | 3 +++ src/services/print.jl | 10 +++++----- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/Project.toml b/Project.toml index b414ecda..b4bb4ee7 100644 --- a/Project.toml +++ b/Project.toml @@ -62,7 +62,7 @@ OrderedCollections = "1.4" Pkg = "1.4, 1.5" ProgressMeter = "1" Random = "1.11" -RecursiveArrayTools = "2, 3" +RecursiveArrayTools = "3" SHA = "0.7, 1" SparseArrays = "1.11" StaticArrays = "1" diff --git a/src/entities/HomotopyDensity.jl b/src/entities/HomotopyDensity.jl index 2e47c28b..7a4a217f 100644 --- a/src/entities/HomotopyDensity.jl +++ b/src/entities/HomotopyDensity.jl @@ -74,6 +74,9 @@ provided by AMP for features like pdf evaluation. - When building a partial belief, use full points with necessary information in the specified partial coords. - Replaces ManellicTree, ManifoldKernelDensity, KernelDensityEstimate, GaussianMixtureModel, PCA, Mixtures - a.k.a. model order reduction given a topology selection + +DevNotes: +- Missing field? When joint tree belief message over Bayes/junction tree separator, we still need to name the dimensions, (x1,x3, l5, ...) """ @kwdef struct HomotopyDensityDFG{T <: StateType, P} """reprkind allows for apples vs apples comparison between density representations. This allows for easy dispatch diff --git a/src/services/print.jl b/src/services/print.jl index dc99213f..66164568 100644 --- a/src/services/print.jl +++ b/src/services/print.jl @@ -58,11 +58,11 @@ function printVariable( println(ioc, " initialized: ", isInitialized(vert, :default)) println(ioc, " marginalized: ", isMarginalized(vert, :default)) println(ioc, " size bel. samples: ", size(vnd.belief.points)) - bws = refBandwidths(vnd) - if !isempty(bws) - print(ioc, " kde bandwidths: ") - println(ioc, round.(first(bws); digits = 4)) - end + # bws = refBandwidths(vnd) + # if !isempty(bws) + # print(ioc, " kde bandwidths: ") + # println(ioc, round.(first(bws); digits = 4)) + # end printstyled(ioc, " VNDs: "; bold = true) println(ioc, solk[smsk], 4 < lsolk ? "..." : "") end From d98c0538009a0b1965d5496fbee9cdac7623a5d4 Mon Sep 17 00:00:00 2001 From: dehann Date: Wed, 24 Jun 2026 14:11:02 -0700 Subject: [PATCH 2/2] stop using incorrect HoDe refs --- src/Deprecated.jl | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/Deprecated.jl b/src/Deprecated.jl index a4c76b9e..5fc22c20 100644 --- a/src/Deprecated.jl +++ b/src/Deprecated.jl @@ -791,11 +791,11 @@ end # But my (JT) preference is for HomotopyBeliefDFG to contain a neutral homotopy tree of nodes # and use tree accessors on the node level and not raw references. -refMeans(state::State) = state.belief.principal_elements -refCovariances(state::State) = state.belief.principal_forms -refWeights(state::State) = state.belief.weights -refPoints(state::State) = state.belief.points -refBandwidth(state::State) = state.belief.trailing_forms[1] -refBandwidths(state::State) = SparseArrays.nonzeros(state.belief.trailing_forms) +# refMeans(state::State) = state.belief.principal_elements +# refCovariances(state::State) = state.belief.principal_forms +# refWeights(state::State) = state.belief.weights +# refPoints(state::State) = state.belief.points +# refBandwidth(state::State) = state.belief.trailing_forms[1] +# refBandwidths(state::State) = SparseArrays.nonzeros(state.belief.trailing_forms) refObservability(state::State) = state.belief.observability -getTopologyKind(state::State) = state.belief.reprkind.topologykind +# getTopologyKind(state::State) = state.belief.reprkind.topologykind