getEdgeAverageMatrix is broken

[dwfmarchant]

getEdgeAverageMatrix in getEdgeToCellCenteredMatrix.jl doesn't work any more. It's still calling getEdgeMassMatrixAnisotropic which no longer exists. Anyone know what the correct replacement is? (maybe @cschwarzbach ?)

[cschwarzbach]

I believe that getEdgeAverageMatrix was intended simply as a wrapper around getEdgeToCellCenteredMatrix. Later, it was tweaked to return the mass matrix computed in a different way. I propose that we return to its original intention and replace the call to getEdgeMassMatrixAnisotropic by a call to getEdgeToCellCenteredMatrix. This change will also align getEdgeAverageMatrix with the similar functions getNodalAverageMatrix and getFaceAverageMatrix.

[dwfmarchant]

So:

function getEdgeAverageMatrix(M::OcTreeMesh)
    if isempty(M.Ae)
         M.Ae, = getEdgeToCellCenteredMatrix(M.S)
    end
    return M.Ae
end

Should be the right fix?

[cschwarzbach]

Yes, from a code organization point of view. However, the implementations of getEdgeToCellCenteredMatrix, getNodeToCellCenteredMatrix and getFaceToCellCenteredMatrix are not quite consistent. I'm not sure what these functions are actually used for; the original and primary purpose was mass matrix construction which has been replaced by improved and designated functions.

[dwfmarchant]

Good point... I can use get getEdgeToCellCenteredMatrix directly for the time being and we can talk about this when you get back.