removed access_token & fixed bug

JohnnyTheTank · JohnnyTheTank · commit 2d4062c555d2 · 2016-06-01T20:01:31.000+02:00
diff --git a/README.md b/README.md
@@ -10,7 +10,6 @@
 # Information
 * **Supported apiNG models: `repo`**
 * This plugin supports the [`get-native-data` parameter](https://aping.readme.io/docs/advanced#parameters)
-* This plugin needs an [access token](#2-access-token) :warning:
 * Used promise library: [angular-github-api-factory](https://github.com/JohnnyTheTank/angular-github-api-factory) _(included in distribution files)_
 
 # Documentation
@@ -20,10 +19,7 @@
     2. Include file
     3. Add dependency
     4. Add plugin
-2. [ACCESS TOKEN](#2-access-token)
-    1. Generate your `access_token`
-    2. Insert your `access_token` into `aping-config.js`
-3. [USAGE](#3-usage)
+2. [USAGE](#3-usage)
     1. Models
     2. Requests
     3. Rate limit
@@ -76,32 +72,7 @@ Add the plugin's directive `aping-github="[]"` to your apiNG directive and [conf
 </aping>
 ```
 
-## 2. ACCESS TOKEN
-
-### I. Generate your `access_token`
-1. Login on [github.com](https://github.com)
-2. Open [github.com/settings/tokens/new](https://github.com/settings/tokens/new)
-    * Remove all scopes except **public_repo**
-    * Generate your access_token
-
-### II. Insert your `access_token` into `aping-config.js`
-Create and open `js/apiNG/aping-config.js` in your application folder. It should be look like this snippet:
-```js
-angular.module('jtt_aping').config(['$provide', function ($provide) {
-    $provide.value("apingDefaultSettings", {
-        apingApiKeys : {
-            github: [
-                {'access_token':'<YOUR_GITHUB_ACCESS_TOKEN>'}
-            ],
-            //...
-        }
-    });
-}]);
-```
-
-:warning: Replace `<YOUR_GITHUB_ACCESS_TOKEN>` with your github `access_token`
-
-## 3. USAGE
+## 2. USAGE
 
 ### I. Models
 Supported apiNG models
diff --git a/bower.json b/bower.json
@@ -4,7 +4,7 @@
   "authors": [
     "Jonathan Hornung <jonathan.hornung@gmail.com>"
   ],
-  "version": "0.7.8",
+  "version": "0.7.9",
   "description": "GitHub plugin for apiNG",
   "main": "dist/aping-plugin-github.min.js",
   "moduleType": [],
diff --git a/demo/index.html b/demo/index.html
@@ -11,23 +11,32 @@
     <script src="../dist/aping-plugin-github.js"></script>
 </head>
 <body ng-app="app">
+
     <h1>Repos by User</h1>
-    <aping template-url="template.html" model="repo" items="40" aping-github="[{'user':'JohnnyTheTank'}]"></aping>
+    <aping template-url="template.html"
+           model="repo"
+           items="40"
+           order-by="updated_timestamp"
+           order-reverse="true"
+           aping-github="[{'user':'JohnnyTheTank'}]">
+    </aping>
+
     <hr>
     <h1>Repo by User and Name</h1>
-    <aping template-url="template.html" model="repo" items="40" aping-github="[{'user':'JohnnyTheTank', 'repo':'apiNG'}]"></aping>
+    <aping template-url="template.html"
+           model="repo"
+           items="40"
+           aping-github="[{'user':'JohnnyTheTank', 'repo':'apiNG'}]">
+    </aping>
     <hr>
-    <h1>Repos by Name</h1>
-    <aping template-url="template.html" model="repo" items="20" aping-github="[{'search':'apiNG', 'sort':'stars', 'order':'desc'}]"></aping>
 
-    <!--
-    <h1>Activity by User</h1>
-    <aping
-            model="activity"
-            items="40"
-            aping-github="[{'user':'passy'}]">
+    <h1>Repos by Name</h1>
+    <aping template-url="template.html"
+           model="repo"
+           items="20"
+           order-by="updated_timestamp"
+           order-reverse="true"
+           aping-github="[{'search':'apiNG', 'sort':'stars', 'order':'desc'}]">
     </aping>
-    <hr>
-    -->
 </body>
 </html>
diff --git a/dist/aping-plugin-github.js b/dist/aping-plugin-github.js
@@ -1,6 +1,6 @@
 /**
     @name: aping-plugin-github 
-    @version: 0.7.8 (03-02-2016) 
+    @version: 0.7.9 (01-06-2016) 
     @author: Jonathan Hornung 
     @url: https://github.com/JohnnyTheTank/apiNG-plugin-github 
     @license: MIT
@@ -31,9 +31,7 @@ angular.module("jtt_aping_github", ['jtt_github'])
                     }
 
                     //create requestObject for api request call
-                    var requestObject = {
-                        access_token: apingUtilityHelper.getApiCredentials(apingGithubHelper.getThisPlatformString(), "access_token"),
-                    };
+                    var requestObject = {};
 
                     if (angular.isDefined(request.items)) {
                         requestObject.per_page = request.items;
@@ -128,7 +126,6 @@ angular.module("jtt_aping_github")
                 var _this = this;
 
                 if (_data.data.constructor === Array) {
-
                     angular.forEach(_data.data, function (value, key) {
                         var tempResult;
                         if (_helperObject.getNativeData === true || _helperObject.getNativeData === "true") {
@@ -141,7 +138,6 @@ angular.module("jtt_aping_github")
                         }
                     });
                 } else {
-
                     if (_data.data.items) {
                         angular.forEach(_data.data.items, function (value, key) {
                             var tempResult;
@@ -159,7 +155,7 @@ angular.module("jtt_aping_github")
                         if (_helperObject.getNativeData === true || _helperObject.getNativeData === "true") {
                             tempResult = _data.data;
                         } else {
-                            tempResult = _this.getItemByJsonData(_data, _helperObject.model);
+                            tempResult = _this.getItemByJsonData(_data.data, _helperObject.model);
                         }
                         if (tempResult) {
                             requestResults.push(tempResult);
@@ -291,7 +287,7 @@ angular.module("jtt_github", [])
         this.fillDataInObjectByList = function (_object, _params, _list) {
 
             angular.forEach(_list, function (value, key) {
-                if (typeof _params[value] !== "undefined") {
+                if (angular.isDefined(_params[value])) {
                     _object.object[value] = _params[value];
                 }
             });
@@ -301,16 +297,18 @@ angular.module("jtt_github", [])
 
         this.getNew = function (_type, _params) {
             var githubSearchData = {
-                object: {
-                    access_token: _params.access_token,
-                },
+                object: {},
                 url: "",
             };
 
-            if (typeof _params.per_page !== "undefined") {
+            if (angular.isDefined(_params.per_page)) {
                 githubSearchData.object.per_page = _params.per_page;
             }
 
+            if (angular.isDefined(_params.access_token)) {
+                githubSearchData.object.access_token = _params.access_token;
+            }
+
             switch (_type) {
                 case "user":
                     githubSearchData.object.per_page = undefined;
@@ -356,7 +354,6 @@ angular.module("jtt_github", [])
                     githubSearchData.url = this.getApiBaseUrl() + "repos/" + _params.user + "/" + _params.repo + "/events";
                     break;
             }
-
             return githubSearchData;
         };
     });
diff --git a/dist/aping-plugin-github.min.js b/dist/aping-plugin-github.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "aping-plugin-github",
-  "version": "0.7.8",
+  "version": "0.7.9",
   "description": "GitHub plugin for apiNG",
   "main": "dist/aping-plugin-github.min.js",
   "scripts": {
diff --git a/src/aping-github-directive.js b/src/aping-github-directive.js
@@ -24,9 +24,7 @@ angular.module("jtt_aping_github", ['jtt_github'])
                     }
 
                     //create requestObject for api request call
-                    var requestObject = {
-                        access_token: apingUtilityHelper.getApiCredentials(apingGithubHelper.getThisPlatformString(), "access_token"),
-                    };
+                    var requestObject = {};
 
                     if (angular.isDefined(request.items)) {
                         requestObject.per_page = request.items;
diff --git a/src/aping-github-helper.js b/src/aping-github-helper.js
@@ -17,7 +17,6 @@ angular.module("jtt_aping_github")
                 var _this = this;
 
                 if (_data.data.constructor === Array) {
-
                     angular.forEach(_data.data, function (value, key) {
                         var tempResult;
                         if (_helperObject.getNativeData === true || _helperObject.getNativeData === "true") {
@@ -30,7 +29,6 @@ angular.module("jtt_aping_github")
                         }
                     });
                 } else {
-
                     if (_data.data.items) {
                         angular.forEach(_data.data.items, function (value, key) {
                             var tempResult;
@@ -48,7 +46,7 @@ angular.module("jtt_aping_github")
                         if (_helperObject.getNativeData === true || _helperObject.getNativeData === "true") {
                             tempResult = _data.data;
                         } else {
-                            tempResult = _this.getItemByJsonData(_data, _helperObject.model);
+                            tempResult = _this.getItemByJsonData(_data.data, _helperObject.model);
                         }
                         if (tempResult) {
                             requestResults.push(tempResult);

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "aping-plugin-github",`
`3`		`- "version": "0.7.8",`
	`3`	`+ "version": "0.7.9",`
`4`	`4`	`"description": "GitHub plugin for apiNG",`
`5`	`5`	`"main": "dist/aping-plugin-github.min.js",`
`6`	`6`	`"scripts": {`
Original file line number	Diff line number	Diff line change
`@@ -24,9 +24,7 @@ angular.module("jtt_aping_github", ['jtt_github'])`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`//create requestObject for api request call`
`27`		`- var requestObject = {`
`28`		`- access_token: apingUtilityHelper.getApiCredentials(apingGithubHelper.getThisPlatformString(), "access_token"),`
`29`		`- };`
	`27`	`+ var requestObject = {};`
`30`	`28`
`31`	`29`	`if (angular.isDefined(request.items)) {`
`32`	`30`	`requestObject.per_page = request.items;`