fix(admin): move form handling to admin_init to fix white screen on save#3
Open
ke-ma-fi wants to merge 1 commit into
Open
fix(admin): move form handling to admin_init to fix white screen on save#3ke-ma-fi wants to merge 1 commit into
ke-ma-fi wants to merge 1 commit into
Conversation
Form submissions were processed inside render_page(), which runs after WordPress has already sent the admin HTML headers. wp_safe_redirect() silently failed, then exit cut the page short mid-HTML. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Moves admin form submission handling out of page rendering and into the standard WordPress admin lifecycle so actions are processed earlier and more consistently.
Changes:
- Hooks
handle_form_submit()toadmin_initinstead of calling it duringrender_page() - Updates
handle_form_submit()visibility topublicto allow WordPress to invoke it as an action callback
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public function __construct() | ||
| { | ||
| add_action('admin_menu', [$this, 'add_menu']); | ||
| add_action('admin_init', [$this, 'handle_form_submit']); |
| } | ||
|
|
||
| private function handle_form_submit(): void | ||
| public function handle_form_submit(): void |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Form submissions were processed inside render_page(), which runs after WordPress has already sent the admin HTML headers. wp_safe_redirect() silently failed, then exit cut the page short mid-HTML.