feat(analyticsevent): InstantPaymentProbe event + AttrHTTPStatus (Layer-3 payment prober)#48
Merged
Conversation
…the Layer-3 payment prober The Layer-3 payment prober (worker/internal/jobs/payment_probe.go — the money heartbeat, forum verdict docs/ci/FORUM-PAYMENT-E2E-TOOLING.md §4) emits one event per probe leg per tick. Add the typed event + helper here so the worker records it via the same fail-open, PII-sanitising Emitter as InstantFlowTest. - EventPaymentProbe = "InstantPaymentProbe". - PaymentProbe type + Attrs() + RecordPaymentProbe() helper. cohort="synthetic" baked in so billing/revenue dashboards exclude probe traffic; the leg is emitted under AttrFlow (the same matrix axis flow tests use). - AttrHTTPStatus = "httpStatus" (new allowlisted, non-PII attribute) for the status code observed on the probed endpoint. Allowlist updated + the existing TestFlowTest_Attrs_AllAllowlisted-style contract continues to hold (AttrHTTPStatus is allowlisted; no PII keys). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mastermanas805
force-pushed
the
feat/analyticsevent-payment-probe
branch
from
4c1e25e to
b9db260
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the typed NR custom event the Layer-3 payment prober (worker
payment_probe.go— the money heartbeat, forum verdictdocs/ci/FORUM-PAYMENT-E2E-TOOLING.md§4) emits one-per-leg-per-tick.What
EventPaymentProbe = "InstantPaymentProbe".PaymentProbetype +Attrs()+RecordPaymentProbe()helper — samefail-open, PII-sanitising
Emittercontract asInstantFlowTest.cohort="synthetic"baked in so billing/revenue dashboards exclude probetraffic; the leg is emitted under
AttrFlow(the same matrix axis flowtests use).
AttrHTTPStatus = "httpStatus"— new allowlisted, non-PII attribute for thestatus code observed on the probed endpoint.
Why first
The worker's
go.modusesreplace instant.dev/common => ../common, andworker CI checks out common's master as the sibling. This PR must merge
before the worker payment-probe PR's CI can pass.
Verification
go build ./...+go vet ./analyticsevent/...green.go test ./analyticsevent/...green (the allowlist contract test still holds—
AttrHTTPStatusis allowlisted, no PII keys leak).🤖 Generated with Claude Code