fix(test): deploy happy-path poll on terminal status, not provider_id#223
Merged
Merged
Conversation
TestDeployNew_SourceImage_FlagOn_Accepted (and its git sibling) polled the row until provider_id was non-empty, then asserted status=="healthy". But runDeploy writes provider_id BEFORE status in two separate UPDATEs, so the poll could break in the window between them and read a transient "building" — a real race in the test, not the compute path. It passed in ci.yml build-and-test but lost the race in deploy.yml's gate, which (now that P3 merged) blocks the api auto-deploy (prod stuck on the P2 SHA). Poll on the terminal status (healthy/failed) so the wait covers the final write. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestDeployNew_SourceImage_FlagOn_Accepted (and its git sibling) polled the row
until provider_id was non-empty, then asserted status=="healthy". But runDeploy
writes provider_id BEFORE status in two separate UPDATEs, so the poll could
break in the window between them and read a transient "building" — a real race
in the test, not the compute path. It passed in ci.yml build-and-test but lost
the race in deploy.yml's gate, which (now that P3 merged) blocks the api
auto-deploy (prod stuck on the P2 SHA). Poll on the terminal status
(healthy/failed) so the wait covers the final write.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com