ci(oasdiff): delete broken workflow, file follow-up#170
Merged
Conversation
The oasdiff workflow references `go run ./cmd/openapi` which does not exist (there is no cmd/openapi/ — only cmd/smoke-buildinfo/). The fall- back chain (`go build ./... && ./api --emit-openapi`) also doesn't work — the api binary doesn't accept --emit-openapi. In practice the workflow's 'Build openapi.json from PR' step always fell through to the 'WARNING: no openapi-emit binary found' echo, comparing prod's spec to prod's spec, so it only ever emitted no-op output. Bug caught by reviews during PR #167 and #168 (mentioned in QA-session PR-3 brief). `fail-on-diff: false` means it was never an actual gate, just noise. Delete and file a tracking issue for the proper wire-up. A real replacement needs ONE of: (a) wire api binary to emit openapi via a CLI flag (--emit-openapi), then update the workflow to invoke it; or (b) add cmd/openapi/main.go that imports internal/handlers/openapi.go and writes the spec to stdout, matching the existing `go run ./cmd/openapi` invocation; or (c) use the live /openapi.json from a build-of-the-PR (run api in docker, hit the endpoint) — slowest but no Go-side code change. Tracking issue filed; until then we have no automated OpenAPI breaking- change check on PRs. The contract-PR surface checklist (CLAUDE.md rule 22) remains the manual gate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete
.github/workflows/oasdiff.yml— the workflow referencesgo run ./cmd/openapiwhich does not exist (nocmd/openapi/package). The fallback chain (./api --emit-openapi) is also unimplemented.With
fail-on-diff: falsethe failure was silent — every run compared prod's spec to prod's spec via the curl fallback. Caught in PR #167 + #168 reviews.Replacement plan (tracked in #169)
Tracking issue #169 carries the proper wire-up plan: a tiny
cmd/openapi/main.gothat importsinternal/handlersand writes the spec to stdout, after which the workflow can be reinstated verbatim withfail-on-diff: trueagainst a baseline.Until that lands the CLAUDE.md rule 22 contract-PR surface checklist is the manual gate.
Tests
No code change — workflow file deletion only. CI gate passes vacuously.
🤖 Generated with Claude Code