Skip to content

Move the provisionStart to the placement for better organization #79

Description

@kerthcet

What would you like to be cleaned:

placement and provisionStart are highly coupled today, if we start the provisioning, we have the start time, then we'll have the placement.

trackedPod {
	provisionStart time.Time

	// placement is what this pod was provisioned against. Two readers: the poll loop files
	// the ready duration under the same dimensions as the provision counters, and DeletePod
	// takes the region the instance is reachable in. Set only where provisionStart is armed.
	placement
}

So maybe a better way is to merge them together and make it a pointer. Storing them in the cache could lead to data loss like Pod restarted, but it's still fine since we can get them from the nodeClaim anyway.

Why is this needed:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.help wantedExtra attention is neededneeds-priorityIndicates a PR lacks a label and requires one.needs-triageIndicates an issue or PR lacks a label and requires one.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions