From 2e944ca2e1ca6e86c1365d7385406e09736c9846 Mon Sep 17 00:00:00 2001 From: wnvko Date: Tue, 24 Feb 2026 16:15:18 +0200 Subject: [PATCH 1/3] fix(grid): update column action height before position it in overlay --- .../grids/core/src/toolbar/grid-toolbar.base.ts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/projects/igniteui-angular/grids/core/src/toolbar/grid-toolbar.base.ts b/projects/igniteui-angular/grids/core/src/toolbar/grid-toolbar.base.ts index 26963fa64e0..93cc074471d 100644 --- a/projects/igniteui-angular/grids/core/src/toolbar/grid-toolbar.base.ts +++ b/projects/igniteui-angular/grids/core/src/toolbar/grid-toolbar.base.ts @@ -21,6 +21,7 @@ import { IgxToggleDirective, ToggleViewCancelableEventArgs, ToggleViewEventArgs @Directive() export abstract class BaseToolbarDirective implements OnDestroy { protected toolbar = inject(IgxToolbarToken); + private cdr = inject(ChangeDetectorRef); /** * Sets the height of the column list in the dropdown. @@ -118,11 +119,18 @@ export abstract class BaseToolbarDirective implements OnDestroy { public toggle(anchorElement: HTMLElement, toggleRef: IgxToggleDirective, actions?: IgxColumnActionsComponent): void { if (actions) { this._setupListeners(toggleRef, actions); - const setHeight = () => + const setHeight = () => { actions.columnsAreaMaxHeight = actions.columnsAreaMaxHeight !== '100%' ? actions.columnsAreaMaxHeight : this.columnListHeight ?? `${Math.max(this.grid.calcHeight * 0.5, 200)}px`; + // TODO: this is a workaround for the issue introduced by Angular's Ivy renderer. + // This was fixed in ToggleDirective by PR16429. However, the fix there introduced the + // issue here. To fix this in IgxColumnActionsComponent we need to set the height after + // the toggle is opened and the classes are applied to ensure the height is calculated + // correctly. + this.cdr.detectChanges(); + } toggleRef.opening.pipe(first()).subscribe(setHeight); } toggleRef.toggle({ From 266be5ac7590a2fe86aa3dd9c9c8bf59f019a0e1 Mon Sep 17 00:00:00 2001 From: wnvko Date: Tue, 24 Feb 2026 16:15:53 +0200 Subject: [PATCH 2/3] chore(grid): update imports and order them --- .../grids/core/src/toolbar/grid-toolbar.base.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/projects/igniteui-angular/grids/core/src/toolbar/grid-toolbar.base.ts b/projects/igniteui-angular/grids/core/src/toolbar/grid-toolbar.base.ts index 93cc074471d..58914d750a4 100644 --- a/projects/igniteui-angular/grids/core/src/toolbar/grid-toolbar.base.ts +++ b/projects/igniteui-angular/grids/core/src/toolbar/grid-toolbar.base.ts @@ -1,13 +1,13 @@ -import { Directive, Input, EventEmitter, OnDestroy, Output, booleanAttribute, inject } from '@angular/core'; +import { ChangeDetectorRef, Directive, EventEmitter, Input, OnDestroy, Output, booleanAttribute, inject } from '@angular/core'; import { Subject, Subscription } from 'rxjs'; import { first, takeUntil } from 'rxjs/operators'; +import { AbsoluteScrollStrategy, AutoPositionStrategy, HorizontalAlignment, OverlaySettings, VerticalAlignment } from 'igniteui-angular/core'; +import { IgxToggleDirective, ToggleViewCancelableEventArgs, ToggleViewEventArgs } from 'igniteui-angular/directives'; +import { IgxColumnActionsComponent } from '../column-actions/column-actions.component'; import { ColumnDisplayOrder } from '../common/enums'; import { IColumnToggledEventArgs } from '../common/events'; -import { IgxColumnActionsComponent } from '../column-actions/column-actions.component'; import { IgxToolbarToken } from './token'; -import { AbsoluteScrollStrategy, AutoPositionStrategy, HorizontalAlignment, OverlaySettings, VerticalAlignment } from 'igniteui-angular/core'; -import { IgxToggleDirective, ToggleViewCancelableEventArgs, ToggleViewEventArgs } from 'igniteui-angular/directives'; /* blazorInclude */ /* blazorElement */ From 65c6e95eba3fa234f45cfe17baf1711f3936de16 Mon Sep 17 00:00:00 2001 From: wnvko Date: Fri, 27 Feb 2026 13:59:54 +0200 Subject: [PATCH 3/3] chore(CI): fix broken coveralls --- .github/workflows/nodejs.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/nodejs.yml b/.github/workflows/nodejs.yml index e82cd8fb27a..0f4e6e1b348 100644 --- a/.github/workflows/nodejs.yml +++ b/.github/workflows/nodejs.yml @@ -72,7 +72,9 @@ jobs: run: npm run build - name: Bundle Tree-Shake & SSR Test run: npm run build:bundletest + # TODO: Remove fail-on-error once Coveralls resolves their ongoing issue (https://status.coveralls.io) - name: Publish to coveralls.io uses: coverallsapp/github-action@v2 with: github-token: ${{ github.token }} + fail-on-error: false